search

FLHDE / freelancer-hd-edition

Freelancer: HD Edition is a mod that aims to improve every aspect of the game Freelancer (2003) while keeping the look and feel as close to vanilla as possible.
https://www.moddb.com/mods/freelancer-hd-edition
184 stars 15 forks source link

Repeated crash after undocking from Battleship York on server #69

Closed BC46 closed 2 years ago

BC46 commented 3 years ago

I came across this repeated crash when I was testing some stuff on my own server. I undocked from Battleship York in Leeds and about 2 seconds later, the game crashes. When I tried joining my server again, I was in space, but my game crashed yet again. This crash cycle continued until I beamed myself to Planet Manhattan in New York manually.

How to reproduce:

1. Enable the Windows 10 compatibility patch when installing this mod

  1. Join the Freelancer Anarchy server 3. Buy a Rhino
  2. Dock at Battleship York in Leeds
  3. Undock

This crash also occurs without the use of any d3d8.dll or d3d9.dll. However, with d3d8to9 the crash no longer happens, so if you disabled the Windows 10 compat patch, you wouldn't have this issue. Also, this issue does not happen on Single Player, regardless of whether or not you use the Win 10 compat patch.

I spent about 2 hours debugging it, and this may sound surreal, but I found out that the crash is caused by 1 or more of the following files:

BC46 commented 3 years ago

I can confirm that DATA/SHIPS/loadouts_special.ini is the culprit. If I take this file from my vanilla Freelancer installation and put that in my HDE folder, I can no longer reproduce the issue.

I should also note that I did not edit this file; it was taken straight from Jason's Freelancer Patch. Need to investigate which exact line changes are causing it by comparing this file to the vanilla one. We should also notify Jason Hood (@adoxa) about this.

BC46 commented 3 years ago

Adoxa claimed to have made the following changes in DATA\SHIPS\loadouts_special.ini:


  rm_b_battleship_br_01, rm_k_battleship_ku_01, rm_l_dreadnought_li_01,
  rm_r_battleship_rh_01, MSN03_Liberty_Dreadnought,
  MSN05_Nomad_Rheinland_Battleship, MSN07_Nomad_Rheinland_Battleship,
  MSN09_Kusari_Battleship, MSN10_Battleship_Osiris, MSN10_Rheinland_Battleship,
  MSN11_Nomad_Liberty_Dreadnought, MSN11_Osirus, or_osiris: deleted tractor
  and/or engine equipment lines (removes not supported/equippable warnings,
  might be a base thing). [* and myself]```
BC46 commented 2 years ago

Fixed in https://github.com/BC46/freelancer-hd-edition/commit/204602f2923d23dd842e14a59946bee7f984ca4e