FLIF-hub / FLIF

Free Lossless Image Format
Other
3.72k stars 229 forks source link

Fix out-of-bounds heap access during metadata encoding from PNG #374

Closed fherzog2 closed 7 years ago

fherzog2 commented 7 years ago

Scenario:

This happens because flif is storing the wrong length for the metadata chunk, namely the length it has in PNG, where the chunk is hex-encoded as text. So flif metadata gets encoded with kbytes of garbage at the end of the chunk.

jonsneyers commented 7 years ago

Thanks for the fix!