search

FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models
7 stars 7 forks source link

OUTRC.DAT #1007

Open FLO-2DKaren opened 1 year ago

FLO-2DKaren commented 1 year ago

I don't think the plugin can make this file. Let's fix this when we fix the boundary widgets.

N 13562 Line 1: IVOLSTOCHAR NNODSTOVO P 1.25 20.5 Line 2: IVOLSTOCHAR DEPTHRT(I,K) VOLRT(I,K) I = Depths K = Volume corresponding to I depths.

N 25146 P 0.00 0.00
P 1.00 5.25
P 2.00 25.2 P 3.00 100.32 P 4.00 180.5

IGRIDXSEC(M) c N or P N = Node line P = storage rating table pairs. NODDSTOVO i 1 - NNOD Grid element with a storage volume rating table (see comment 1). DEPTHRT r 0 - inf Increment flow depth for the volumetric rating table above the lowest elevation in the grid element topographic data base. VOLRT r 0 - inf Volume for each incremental depth.

FLO-2DNoemi commented 5 months ago

Is the creation of the file OUTRC.DAT already included in plugin 1.0?

This file contains the grid element storage volume rating tables that define variable volumes as a function of flow depths. when this file exists, the storage volume rating tables are used instead of the uniform elevation for each cell.

rpachaly commented 4 months ago

@FLO-2DNoemi @FLO-2DKaren

It is done! Please, check this video:

https://flo-2d.sharefile.com/d-s226634e0ce6f495aa6e842b3f7ab7449

I'm pretty happy with the approach that I used and the results obtained. But not so much with the performance of the algorithm. It is on the pull request https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1362

Let me know what you think.

FLO-2DNoemi commented 4 months ago

@Robson Pachaly @.***>

This looks fine to me.

Please see my comments below:

When you said in the video that the minimum number of points was hardwired to 20. Does this mean that the calculation always checks that at least there are 20 points inside each cell besides the values entered by the user? I remember GDS has 20 as the minimum number of points in the cell. What happens if the user changes this to 5 or something else in QGIS?

Can you send me the project data files and geopackage? I want to double-check the code for this component in the FLOPRO.exe.

Thanks,

Noemi

On Wed, May 29, 2024 at 1:12 PM Robson Pachaly @.***> wrote:

@FLO-2DNoemi https://github.com/FLO-2DNoemi @FLO-2DKaren https://github.com/FLO-2DKaren

It is done! Please, check this video:

https://flo-2d.sharefile.com/d-s226634e0ce6f495aa6e842b3f7ab7449

I'm pretty happy with the approach that I used and the results obtained. But not so much with the performance of the algorithm. It is on the pull request #1362 https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1362

Let me know what you think.

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1007#issuecomment-2137897089, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3T6AEU23ZPXOGOZPWLZEYD6DAVCNFSM6AAAAAA5XZGHGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXHA4TOMBYHE . You are receiving this because you were mentioned.Message ID: @.***>

rpachaly commented 4 months ago

The user can set the minimum number of points inside each cell, it does not need to be necessarily 20. But I can make it hardwired to 20 if you want. If the user set it to 5, the minimum points to compute the OUTRC for that specific cell will be 5.

The export/import code is still not ready. I'll try to have it done by tomorrow. I created the table on the geopackage and totally forgot to make the export code, my bad.

FLO-2DNoemi commented 4 months ago

Got it, thanks. I like the option to let the user decide the minimum number pf points needed in the cell. We can add a discussion on this in the manual.

Send me the data files as soon as you have it and I will test it with the engine.

On Thu, May 30, 2024 at 12:13 PM Robson Pachaly @.***> wrote:

The user can set the minimum number of points inside each cell, it does not need to be necessarily 20. But I can make it hardwired to 20 if you want. If the user set it to 5, the minimum points to compute the OUTRC for that specific cell will be 5.

The export/import code is still not ready. I'll try to have it done by tomorrow. I created the table on the geopackage and totally forgot to make the export code, my bad.

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1007#issuecomment-2140111144, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3SKWAEGME7FUE3MVELZE5FZVAVCNFSM6AAAAAA5XZGHGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQGEYTCMJUGQ . You are receiving this because you were mentioned.Message ID: @.***>

rpachaly commented 4 months ago

Now the OUTRC code it is fully implemented on this pull request

Noemi, here are the two projects that I used for testing (gpkg and *.dat files):

https://flo-2d.sharefile.com/d-s2678dca375084fa0aa02462a7bc31afc

https://flo-2d.sharefile.com/d-s7c9f0026aea54c11957e40762691d085

FLO-2DKaren commented 4 months ago

We can run it on the self help kit but maybe we should set the cell size to 50.

rpachaly commented 4 months ago

The pixel size is 1 foot, it will take a lot of time to process it.

FLO-2DNoemi commented 4 months ago

Thanks, Robson, got them.

On Thu, May 30, 2024 at 4:02 PM Robson Pachaly @.***> wrote:

Now the OUTRC code it is fully implemented on this pull request https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1362

Noemi, here are the two projects that I used for testing (gpkg and *.dat files):

https://flo-2d.sharefile.com/d-s2678dca375084fa0aa02462a7bc31afc

https://flo-2d.sharefile.com/d-s7c9f0026aea54c11957e40762691d085

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1007#issuecomment-2140777897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3S7ZWPGRA5GUTX7QKTZE6AUVAVCNFSM6AAAAAA5XZGHGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQG43TOOBZG4 . You are receiving this because you were mentioned.Message ID: @.***>

FLO-2DKaren commented 4 months ago

I know but if you can't use the tool on large datasets it is a problem we can solve.

rpachaly commented 4 months ago

Multithread is the solution I think. But first let's be sure it is working the way we want in small datasets and then we add the multithread algorithm.

FLO-2DKaren commented 4 months ago

Look at the Lidar processing code. It doesn't use multithread. It uses numpy. It's super fast. We could also look at the PDAL libraries.