Closed FLO-2DKaren closed 6 months ago
@FLO-2DJJ
Hi JJ,
You can start on this one. It is well documented in the EPA SWMM Gui so you should have pretty excellent info there.
Don't add any of those bad table editors on this one. Let's figure out a better way to build tables. Your method doesn't have a copy paste capability and that makes them very hard to use.
Add it to the Node group.
Hi @FLO-2DKaren, @FLO-2DNoemi,
How much of the 'Inflows' functionality of the storage units is to be included in the FLO-2d plugin? According to the EPA SWMM Gui when the variable 'Inflows' is YES several panels are open to enter data:
The [...] button opens this dialog with 3 tabs: Direct, Dry Weather, RDII:
In turn, other dialogs can be selected with more options. For instance, the 'Unit Hydrograph Group' of RDII opens this dialog:
And so for other options like 'Baseline Pattern', 'Time Series', and 'Time Patterns'.
Take into account that all that data needs to be read/written from/to SWMM.INP (groups [CURVES], [TIMESERIES], [PATTERNS], [RDII], [HYDROGRAPHS], and maybe others.
Again, how much of that functionally is to be included in this District task?
@FLO-2DNoemi @rpachaly @FLO-2DJJ
Hi All,
I'm trying to anticipate what sort of Data a FLO-2D storage unit would need.
Some of the storage units are closed like a cistern and some are open like a basin. We don't want to add an open storage unit to the grid, but I suppose we could still use an offsite storage unit that could interface with rainfall.
For example, North Mesa has a basin that is south of the project but interfaces with our channel at a culvert. We could model it as a storage unit instead of a basin that is built into the grid.
We need to identify which data will be used on a FLO-2D storage unit system. Maybe we can have a meeting about this next week.
@FLO-2DJJ @FLO-2DKaren I reviewed the SWMM manual and GUI for the creation of the storage units (SU) data and I am adding below my comments. We can discuss this anytime if it is needed.
Let's think about SU as an inlet with additional storage capacity. A SU is very similar to a manhole but with water storage capacity. To calculate the storage capacity, the SU needs tabular data with 2 columns: Depth of water vs Area or a functional curve that defines the stage-storage condition.
The image below shows the data in red that is required to simulate SU in FLO-2D:
From the windows above:
Invert Elevation, Max Depth and Initial Depth, there should be no difference with what is already implemented in the elevation field for inlets.
Infiltration through the bottom of the SU: we may need to use the infiltration calculation (GREEN-AMPT) from SWMM, the reason is that this infiltration is calculated through the bottom of the SU, and this is part of the Storm Drain layer, it is no part of the surface layer. @FLO-2DKaren let's discuss this anytime during this coming week so we can provide details to JJ.
Storage Curve, Functional Curve data and Tabular curve is the data that characterize the SU. This data constitutes the core of this task. This is the specific data for SU.
@FLO-2DNoemi, @FLO-2DKaren Thanks for the additional information. Let's have a meeting to clarify some details. In particular, but not exclusively:
These are some sub-tasks of this issue so far (done or to do):
Hi @FLO-2DJJ
Can we already start testing this task in the current plugin from GITHUB?
Wait until I finish a main Storage Units dialog (to be called from the Nodes list in the Storm Drains widget). What I have already done might change as the code progresses. The branch I uploaded is intended as a backup which will be converted to a pull request when ready for your testing and approval.
Make use of the CurveEditorDialog to be defined in issue #1169 Make OutfallTidalCurveDialog class more general
Here you have a video of what I already done for Storage Units in the plugin:
Please, look at it.
Hi JJ,
It is looking really good!
Hi JJ,
I found a few issues.
I'm at a loud hotel so I didn't record sound.
JJ,
Here is my test project.
@rpachaly Hi Robson, You might want this advanced test project too. It's a nice one.
Thanks Karen,
I'll check them out.
I may make points 2, 3, and 4 as new issues after I see their complexity.
Do you have the .DAT and SWMM files for this project? Some of the issues could be pinpointed and corrected during their loading.
Juan Jose Rodriguez FLO-2D Software www.flo-2d.com @.***
On Thu, Mar 7, 2024 at 4:15 AM Karen @.***> wrote:
Hi JJ,
I found a few issues.
- I couldn't finish your video. Sorry It stopped when you were talking about green ampt.
- How do you fill in the grid attribute? Do you do it manually. I thought it might fill in when I used schematize.
- I guess we do need a shapefile assignment like the others. I have a test project for you.
- I think you need to fix the auto assign link for weir, pump, and orifice. I got a video here:
I'm at a loud hotel so I didn't record sound.
— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1048#issuecomment-1982271132, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O75J7G5ZK6VMPVRTRIDYW7LUJAVCNFSM6AAAAAA7OLLUW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSGI3TCMJTGI . You are receiving this because you were mentioned.Message ID: @.***>
I know that the DAT files and SWMM files can be created from the plugin but I just want to know if the original swmm.inp is created from EPA SWMM or other source.
Juan Jose Rodriguez FLO-2D Software www.flo-2d.com @.***
On Thu, Mar 7, 2024 at 5:57 AM Juan Jose Rodriguez @.***> wrote:
Thanks Karen,
I'll check them out.
I may make points 2, 3, and 4 as new issues after I see their complexity.
Do you have the .DAT and SWMM files for this project? Some of the issues could be pinpointed and corrected during their loading.
Juan Jose Rodriguez FLO-2D Software www.flo-2d.com @.***
On Thu, Mar 7, 2024 at 4:15 AM Karen @.***> wrote:
Hi JJ,
I found a few issues.
- I couldn't finish your video. Sorry It stopped when you were talking about green ampt.
- How do you fill in the grid attribute? Do you do it manually. I thought it might fill in when I used schematize.
- I guess we do need a shapefile assignment like the others. I have a test project for you.
- I think you need to fix the auto assign link for weir, pump, and orifice. I got a video here:
I'm at a loud hotel so I didn't record sound.
— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1048#issuecomment-1982271132, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O75J7G5ZK6VMPVRTRIDYW7LUJAVCNFSM6AAAAAA7OLLUW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSGI3TCMJTGI . You are receiving this because you were mentioned.Message ID: @.***>
Hi JJ, Here is the .DAT and .inp files. I converted nodes to storage units in EPA SWMM. So the storage units are from EPA SWMM GUI.
Thanks, I'll check them out.
On Thu, 7 Mar 2024, 2:00 pm Karen, @.***> wrote:
Hi JJ, Here is the .DAT and .inp files. I converted nodes to storage units in EPA SWMM. So the storage units are from EPA SWMM GUI.
Dat and inp files.zip https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/files/14524308/Dat.and.inp.files.zip
— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1048#issuecomment-1983458135, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O7YDOGTUPAYCOW6W5KTYXBQHJAVCNFSM6AAAAAA7OLLUW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTGQ2TQMJTGU . You are receiving this because you were mentioned.Message ID: @.***>
Completed. This related issue will be addressed next: Add Storage Units to 'Select components from shapefile layer' #1228
Build Storage units with plugin