FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models
5 stars 7 forks source link

storm drain checkbox and help button #1298

Closed FLO-2DKaren closed 2 months ago

FLO-2DKaren commented 2 months ago

@FLO-2DJJ

This isn't important. It is a little annoying

  1. Whenever you reload a project, the Simulate Storm Drain checkbox is unchecked. I recommend that you connect this to the Simulate Storm Drain switch in the Control Variables tab. That way, the switch will stop turning off unless someone actually turns it off.

image

image

  1. Help button. Please connect it to help.svg instead of help_contents.svg because we're going to put these in more places and I'd like to use the simpler help button.

  2. Can you remove this button? We're going to do this through MapCrafter. It's already finished. We just need to merge it.

image

FLO-2DKaren commented 2 months ago

@FLO-2DJJ While you are at this, we may as well fix this too.

Remove the Greyed out buttons. We don't use them anyway.

Move the Import Export inp buttons to this top small button area. I attached the import export buttons in the zipped file below.

image

import export swmm buttons.zip

FLO-2DKaren commented 2 months ago

@FLO-2DJJ Hi JJ,

Can you add this ui file to that branch with the pull request? I'm adding tooltips to the variable labels but I don't have a cloned version on this computer.

cont_toler_jj.zip

FLO-2DJJ commented 2 months ago

Hi @FLO-2DKaren,

The cont_toler_jj.ui file is already in the branch

https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/tree/storm_drain_checkbox_and_help_button_(Issue_%231298)

Isn't it what you want?

It has not been modified. It's the same found in the master branch.

FLO-2DKaren commented 2 months ago

I just added tool tips so it won't look different.

FLO-2DJJ commented 2 months ago

I just added tool tips so it won't look different.

Great @FLO-2DKaren . I pushed your changes to _cont_tolerjj.ui to pull request PR #1300

FLO-2DJJ commented 2 months ago

Solved and merged into master with pull request #1300.