search

FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models
6 stars 7 forks source link

Mesh generator issue #1301

Closed FLO-2DKaren closed 4 months ago

FLO-2DKaren commented 5 months ago

We need to create grids that do not have dangling grid elements. Meaning a grid element that has a connection of only a diagonal or only one compass direction. I'll get a video.

FLO-2DKaren commented 4 months ago

@rpachaly Let's have a meeting about this. It is more important than it sounds.

rpachaly commented 4 months ago

Hi Karen,

Ok! Let me know when you're available and send me the meeting link.

rpachaly commented 4 months ago

I did a code that removes the dangling elements.

Quick question: must the grid fid be in order? If I remove one, there will be a missing fid. Something like

fid 1 2 3 -\ Grid element 4 was removed because it was a dangling element. 5 -/ 6 7

FLO-2DKaren commented 4 months ago

hmmmmm I am not sure about that. Some things would work and some things wouldn't.

@FLO-2DNoemi What do you think Noemi?

rpachaly commented 4 months ago

Ok, in doubt, I'll reassign the fids.

FLO-2DNoemi commented 4 months ago

It is better to reassign the FIDS even though most of the components I am sure will be OK and functional, it is the connectivity between cell sides that controls most of the cell interaction. The only potential issue that I can foresee is the identification of internal channel elements. The calculation method for this is quite intricate, and in the past, even minor issues like a missing FID have caused problems.

On Fri, May 10, 2024 at 3:01 PM Robson Pachaly @.***> wrote:

Ok, in doubt, I'll reassign the fids.

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1301#issuecomment-2105124686, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3XKFOKXSBRNKYLVP2TZBUKP3AVCNFSM6AAAAABHCCIQTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGEZDINRYGY . You are receiving this because you were mentioned.Message ID: @.***>

rpachaly commented 4 months ago

This is done on https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1308. Check the video.

https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/assets/39889306/4fa61d09-ceca-4ac6-8557-3de555196dc7

FLO-2DKaren commented 4 months ago

Excellent Robson. I think the time we lose to the extra processing is worth not having to find and fix those if we run into problems with them.