search

FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models
6 stars 7 forks source link

Horton Initial Abstraction #1302

Closed FLO-2DKaren closed 4 months ago

FLO-2DKaren commented 5 months ago

Horton needs to have initial abstraction for the v1.0.0 release.

https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/assets/20424460/a6ac06ee-be3d-40a1-9219-2afe487bb638

rpachaly commented 5 months ago

Ok, this seems easy to do. I'll try to have it done by tomorrow.

rpachaly commented 5 months ago

This is done. I recorded a nice video explaining but my internet is not helping

rpachaly commented 5 months ago

https://drive.google.com/file/d/1cd_ZagRxEA0uQeBre5jaQb3bP1Qav3iZ/view?usp=sharing

rpachaly commented 5 months ago

I had to upload the video on the drive. @FLO-2DKaren check if this is what you were expecting, especially the way that I convert the Initial Abstraction to english units. The pull request is open, you can merge it if you think it is ok.

@FLO-2DNoemi I did a small changed on the hdf5 infiltration. Check around 6 minutes of the video.

FLO-2DKaren commented 4 months ago

Hi Robson,

This is super counter intuitive but FLO-2D Horton doesn't have a metric system setup so you always use english system for Horton.

So you do not need that converter tool that you applied. We can have a meeting if you need.

rpachaly commented 4 months ago

Ok! I'm going to remove it then and push the branch again.

rpachaly commented 4 months ago

I just removed it but not tested. It was just two if statements when exporting. It should be fine. On https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1303

FLO-2DKaren commented 4 months ago

OK I still need to document it so I'll test it when I fix the documentation

FLO-2DKaren commented 4 months ago

tested