search

FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models
6 stars 7 forks source link

Storm Drain Shapefile Field Select #1320

Closed FLO-2DKaren closed 4 months ago

FLO-2DKaren commented 4 months ago

Hi JJ,

I modified the Storm Drain Shapefile UI file so it was aligned a little better. Can you update it?

I also wanted some feedback on that Ponded Area field. I assume it is disabled. Maybe we should Grey it out. See Video

https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/assets/20424460/338a8a61-88f9-4a59-8ae0-6d6f5f357546

storm_drain_shapefile.zip

FLO-2DNoemi commented 4 months ago

Hi everyone,

We should get rid of the ponded area.

The plugin should be able to read a file with the ponded area, we do not need this data but the plugin should be able to read an inp that includes this data, and the plugin should be able to write the INP including the ponded area columns, it must be zero for all cases and features. We need to be able to read an inp file with ponded areas and write an inp file including ponded areas columns because they are needed for compatibility with EPA SWMMGUI.

In other words, we do not use this feature because this is a completely wrong simplification that EPA SWMM uses. I thought we discussed this weeks ago but I may be wrong.

[JUNCTIONS] ;; Invert Max. Init. Surcharge Ponded ;;Name Elev. Depth Depth Depth Area ;;-------------- ---------- ---------- ---------- ---------- ---------- J1-36-30-29-A 1395.80 4.20 0.00 0.00 0.00 I2-36-30-71 1397.00 2.20 0.00 0.00 0.00 I2-36-30-41 1390.40 5.50 0.00 0.00 0.00 I2-36-30-46 1397.40 5.00 0.00 0.00 0.00 I2-36-30-39 1387.20 4.20 0.00 0.00 0.00 I2-36-31-37 1407.70 6.30 0.00 0.00 0.00

[STORAGE] ;; Invert Max. Init. Storage Curve

We can have a meeting if a discussion is needed. Noemi

On Tue, May 14, 2024 at 10:22 AM Karen @.***> wrote:

Hi JJ,

I modified the Storm Drain Shapefile UI file so it was aligned a little better. Can you update it?

I also wanted some feedback on that Ponded Area field. I assume it is disabled. Maybe we should Grey it out. See Video

https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/assets/20424460/338a8a61-88f9-4a59-8ae0-6d6f5f357546

storm_drain_shapefile.zip https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/files/15309774/storm_drain_shapefile.zip

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1320, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3X2TE3BJ7GRAFB73DTZCIM2LAVCNFSM6AAAAABHWJMWTSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4TKNRSGMYDIMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

FLO-2DNoemi commented 4 months ago

We are getting ready to submit the plugin to FCD this week. I would like to submit a plugin with no ponded area hanging out, this has been an issue for a long time.

On Tue, May 14, 2024 at 10:34 AM Noemi Gonzalez @.***> wrote:

Hi everyone,

We should get rid of the ponded area.

The plugin should be able to read a file with the ponded area, we do not need this data but the plugin should be able to read an inp that includes this data, and the plugin should be able to write the INP including the ponded area columns, it must be zero for all cases and features. We need to be able to read an inp file with ponded areas and write an inp file including ponded areas columns because they are needed for compatibility with EPA SWMMGUI.

In other words, we do not use this feature because this is a completely wrong simplification that EPA SWMM uses. I thought we discussed this weeks ago but I may be wrong.

[JUNCTIONS] ;; Invert Max. Init. Surcharge Ponded ;;Name Elev. Depth Depth Depth Area ;;-------------- ---------- ---------- ---------- ---------- ---------- J1-36-30-29-A 1395.80 4.20 0.00 0.00 0.00 I2-36-30-71 1397.00 2.20 0.00 0.00 0.00 I2-36-30-41 1390.40 5.50 0.00 0.00 0.00 I2-36-30-46 1397.40 5.00 0.00 0.00 0.00 I2-36-30-39 1387.20 4.20 0.00 0.00 0.00 I2-36-31-37 1407.70 6.30 0.00 0.00 0.00

[STORAGE] ;; Invert Max. Init. Storage Curve

  • Ponded *Evap. ;;Name Elev. Depth Depth Curve Params
    • Area * Frac. Infiltration Parameters ;;-------------- -------- -------- -------- ---------- -------- --------

      I5-38-30-5 1420.55 5.10 50 FUNCTIONAL 1000 0 0 40 40 10 20 30

We can have a meeting if a discussion is needed. Noemi

On Tue, May 14, 2024 at 10:22 AM Karen @.***> wrote:

Hi JJ,

I modified the Storm Drain Shapefile UI file so it was aligned a little better. Can you update it?

I also wanted some feedback on that Ponded Area field. I assume it is disabled. Maybe we should Grey it out. See Video

https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/assets/20424460/338a8a61-88f9-4a59-8ae0-6d6f5f357546

storm_drain_shapefile.zip https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/files/15309774/storm_drain_shapefile.zip

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1320, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3X2TE3BJ7GRAFB73DTZCIM2LAVCNFSM6AAAAABHWJMWTSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4TKNRSGMYDIMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

FLO-2DJJ commented 4 months ago

Hi @FLO-2DKaren,

You said:

I also wanted some feedback on that Ponded Area field. I assume it is disabled. Maybe we should Grey it out.

I think you are using an old strorm_drain_shapefile.ui

The current one doesn't have ponded area:

image

FLO-2DNoemi commented 4 months ago

@Karen OBrien @.***>

Once you check the latest version if the ponded area is still there, then we need to remove it, do not grey it out, that is confusing for users.

On Tue, May 14, 2024 at 10:41 AM Juan Jose @.***> wrote:

Hi @FLO-2DKaren https://github.com/FLO-2DKaren,

You said:

I also wanted some feedback on that Ponded Area field. I assume it is disabled. Maybe we should Grey it out.

I think you are using an old strorm_drain_shapefile.ui

The current one doesn't have ponded area:

image.png (view on web) https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/assets/20424575/cf303d28-bb36-4f70-926d-b59d5994b7a1

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1320#issuecomment-2110426531, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3SOPV5FEZ2GKXXE2ZTZCIPA5AVCNFSM6AAAAABHWJMWTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGQZDMNJTGE . You are receiving this because you commented.Message ID: @.***>

FLO-2DJJ commented 4 months ago

Hi @FLO-2DKaren and @FLO-2DNoemi,

Please check the current master. The ponded area was eliminated 3 days ago with issue #1229, and pull request #1307

FLO-2DKaren commented 4 months ago

@FLO-2DJJ

JJ, I think I got that UI file from an old zipped file. I opened by searching ui instead of loading the plugin window.

Which sucks because it was a pain in the neck to fix those dialog boxes. But I can do it again on the new window. I'm going to close this issue.