1327 swmmoutf issue - Githubissues

FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models

5 stars 7 forks source link

1327 swmmoutf issue #1329

Closed FLO-2DJJ closed 1 month ago

FLO-2DJJ commented 1 month ago

Outfalls dialog:

When the 'Allow Discharge' checkbox is checked, the Allow Discharge column is set to 1/0.
On loading, the Allow Discharge column is set to 1 or 0.
Save the Allow Discharge values to _outfflo field of swmmoutf table (SD Outfalls layer).
Saves/Loads SWMMOUTF.DAT according to edits described above.

FLO-2DJJ commented 1 month ago

@FLO-2DKaren, @FLO-2DNoemi,

Please review this pull request. The changes/fixes to see are described the first comment above.

At this moment, it can be merged into master without conflicts.

FLO-2DKaren commented 1 month ago

JJ, It needs to be 0, 1 or 2 so the checkbox is not needed. You can use a combo box or let the people edit it in the table.

FLO-2DJJ commented 1 month ago

Hi @FLO-2DKaren,

JJ, It needs to be 0, 1 or 2 so the checkbox is not needed. You can use a combo box or let the people edit it in the table.

This is new. Could you please document it, to see the logic behind this change, and adapt it to the code.

FLO-2DJJ commented 1 month ago

@FLO-2DKaren,

Before this:

SWMMOUTF AllowQ is no longer true false. It is now 0, 1, or 2

I had already changed the plugin to remove True/False and change it to 1/0 in all the code related to Allow Discharge. That was according to a previous video you sent to me. I did it in a code that was integrated to pull request https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1329

The fact that Allow Discharge is now 0,1,2 is new. Could you please document it, so I can see the logic behind this change, and adapt it to the code.

Please, do not merge this pull request until the final range of AllowQ is clarified.

FLO-2DJJ commented 1 month ago

This pull request was not finished yet:

Please, do not merge this pull request until the final range of AllowQ is clarified.

It's about to be finished, but needs a couple of additions.

FLO-2DKaren commented 1 month ago

I expected it to be finished yesterday so I can wrap up my documentation and testing.

FLO-2DJJ commented 1 month ago

I expected it to be finished yesterday so I can wrap up my documentation and testing.

That's OK. I created a new branch to finish it #1335.