Import swmm.inp issue - Githubissues

FLO-2DKaren commented 1 month ago

We need to change the swmm_allow_dishcharge default to 0, 1 or 2

The Storm Drain Node table in User layer is still set to false when importing an INP.

https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/assets/20424460/e469d019-2481-4ad0-906c-b0dcf1ebe0db

FLO-2DKaren commented 1 month ago

Components Save Message is wrong.

Move this message to the message bar.

Inlet/Junction node message is wrong message and in the wrong place. Outfall message not available. Storage Unit message is OK.

The Conduits save message is in the right place but is the wrong message. Pumps, weirs, orifices messages all wrong.

FLO-2DKaren commented 1 month ago

Should this be integer

FLO-2DKaren commented 1 month ago

@FLO-2DJJ

JJ, Can you fix this? I want to merge Robson's code into the master and then get you to fix this. We should be really close to finishing this but Robson's working on SD Control Branch and I think it's easier to merge that with the master so you can branch it yourself.

FLO-2DKaren commented 1 month ago

OK JJ, you can branch off the Master to fix this.

FLO-2DJJ commented 1 month ago

@FLO-2DKaren,

Before continuing with this issue: It seems to me that the plugin you were using in the video was not the current one because The (disabled) column in inlets/junctions dialog has been hidden in the master for several days now.

FLO-2DKaren commented 1 month ago

I know JJ. That's why I merged that plugin into the master. You can work from the master. It's still importing wrong. I'll get you a test project to import with.

FLO-2DKaren commented 1 month ago

Test project Blank self help for storm drain testing.zip

inp for importing SWMM.zip

FLO-2DJJ commented 1 month ago

I know JJ. That's why I merged that plugin into the master. You can work from the master. It's still importing wrong. I'll get you a test project to import with.

OK. Thank you. I'm at it.

FLO-2DJJ commented 1 month ago

@FLO-2DKaren, In the end, should the _swmm_allowdischarge default value be 0 or 1? Currently, it is assigned to 0 in the table and wherever a value is missing.

FLO-2DKaren commented 1 month ago

Default it to 0 if it's missing. I might change my mind later but for now 0.

FLO-2DNoemi commented 1 month ago

The default value should be zero.

On Tue, May 28, 2024 at 12:35 PM Karen @.***> wrote:

Default it to 0 if it's missing. I might change my mind later but for now 0.

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1359#issuecomment-2135683535, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3RX2JGR4RBYNN3ACZTZESW55AVCNFSM6AAAAABIM6L3R2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZVGY4DGNJTGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

FLO-2DKaren commented 1 month ago

JJ I made a note on the pull request but I'll add it here too . The messages also need to be fixed.

FLO-2DKaren commented 1 month ago

[x] Video1 7:20 The pump data is not connecting to the Pump Curves when we import an INP.
[x] Video1 7:30 Should we Connect the Type 4 list to the Type 4 table editor when we import an INP.
[ ] Video 1 Noemi, Can you look at the video at 11:00 and is this OK?

https://flo-2d.sharefile.com/d-sb75c964972254b599da30077371f31dc

@FLO-2DNoemi heres the video link. Is that what you want!! Min 11:00

FLO-2DKaren commented 1 month ago

[x] Video 2 7:00 Storage Curve Description not Importing.
[ ] Video 2 8:15 The Outfall editor seems to be connected to the schematized table. I think it should be connected to the user table.

https://flo-2d.sharefile.com/d-s6ac638c81c8b4255ad926b964ca3962a

FLO-2DSoftware / qgis-flo-2d-plugin

Import swmm.inp issue #1359