search

FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models
5 stars 7 forks source link

Sd vertices #1366

Closed rpachaly closed 3 weeks ago

FLO-2DJJ commented 4 weeks ago

@rpachaly,

There is an error in line 1078 of _swmmio.py (a try with a except commented)

rpachaly commented 4 weeks ago

@rpachaly,

There is an error in line 1078 of _swmmio.py (a try with a except commented)

Is it an easy fix? I'm working on other stuff and I did not want to change gears now.

FLO-2DJJ commented 4 weeks ago

Seems easy to me. But it may have some other implications. Fix it when you can.

Juan Jose Rodriguez FLO-2D Software www.flo-2d.com @.***

On Tue, Jun 4, 2024 at 7:20 PM Robson Pachaly @.***> wrote:

@rpachaly https://github.com/rpachaly,

There is an error in line 1078 of swmm_io.py (a try with a except commented)

Is it an easy fix? I'm working on other stuff and I did not want to change gears now.

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1366#issuecomment-2148039057, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O7Y7HPNFDVLD4R66KPLZFXZOZAVCNFSM6AAAAABITRYHGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYGAZTSMBVG4 . You are receiving this because you commented.Message ID: @.***>

FLO-2DJJ commented 3 weeks ago

@FLO-2DKaren, @rpachaly

The mentioned error (try...except) fixed, and warning/errors numbers changed.

Please test it and merge if satisfied.

rpachaly commented 3 weeks ago

I just redid my testing here. All good. Only change is that I moved the curve message to the log.