FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models
5 stars 7 forks source link

SD Editor - testing #1385

Open rpachaly opened 3 days ago

rpachaly commented 3 days ago

I'm going to create this issue to facilitate the tracking of testing. It will be divided into the portions of the code modified by the new Storm Drain Editor and the projects used for testing.

IMPORT FROM INP

EXPORT TO INP

CREATE MANUALLY THE STORM DRAIN FEATURES

INFO TOOL

SELECT FROM SHAPEFILES

SCHEMATIZE DATA

EXPORT DAT

EXPORT HDF5

OUTSIDE NODES

@FLO-2DKaren feel free to modify and suggest more projects for testing.

FLO-2DKaren commented 1 day ago

When you import a project the last thing it imports is the inp. Does this force all inlet types to type 1. Do we need to schematize as the last step.

FLO-2DNoemi commented 1 day ago

This is incorrect. We should always read the inlet type from the SWMMFLO.DAT file. The INP file does not store any data for the inlet type, so there is no reason to reset all inlets to type 1. This needs to be fixed.

On Mon, Jul 1, 2024 at 12:18 PM Karen @.***> wrote:

When you import a project the last thing it imports is the inp. Does this force all inlet types to type 1. Do we need to schematize as the last step.

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1385#issuecomment-2200565697, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3VKP3Z25QOGM4ZB7NDZKF6M7AVCNFSM6AAAAABKDHAKQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGU3DKNRZG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

FLO-2DKaren commented 1 day ago

It's OK Noemi. We know this but we are conducting tests to understand the processes we need to use when we import a complete project vs only an inp file.

FLO-2DNoemi commented 1 day ago

Ok, thanks for the clarification.

On Mon, Jul 1, 2024 at 12:43 PM Karen @.***> wrote:

It's OK Noemi. We know this but we are conducting tests to understand the processes we need to use when we import a complete project vs only an inp file.

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1385#issuecomment-2200606229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3QUBEUHSCEIJHKRTILZKGBJZAVCNFSM6AAAAABKDHAKQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGYYDMMRSHE . You are receiving this because you commented.Message ID: @.***>