FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models
6 stars 7 forks source link

Walls still need to be inside user layers #1457

Closed rpachaly closed 1 month ago

rpachaly commented 1 month ago

Walls still need to be inside user layers or they won't work.

Originally posted by @FLO-2DKaren in https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1454#issuecomment-2269849987

rpachaly commented 1 month ago

To solve this issue, I had to set the groups=None in the save_edits_and_proceed function. This impacts the following layers:

By impact I mean that they don't need to be inside any group to perform its processes. Which I think is OK because of the duplicate layer code. Let me know what you think.

Done on https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1465

FLO-2DKaren commented 1 month ago

OK I'll do a rapid run through self help kit to see if anything comes up.

FLO-2DKaren commented 1 month ago

walls error

error message ERROR 051218.1146: couldn't load point or/and line layers!


Error: AttributeError: 'NoneType' object has no attribute 'type'

In file: C:\Users/Karen/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\flo2d\gui\dlg_walls_shapefile.py

In function: setup_layers_comboxes

On line 87: ^^^^^^^^^^^^^^^^

FLO-2DKaren commented 1 month ago

Maybe we should put this back.

rpachaly commented 1 month ago

I cannot reproduce the bug here. Can you send me the geopackage?

I'm investigating the code and I don't think this is related to the changes that I did on https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1465. Maybe it is another issue.

FLO-2DKaren commented 1 month ago

It was a fluke. Working fine now.

rpachaly commented 1 month ago

I'm going to close this issue