search

FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models
8 stars 8 forks source link

Levee data set two sides #1528

Open rpachaly opened 2 months ago

rpachaly commented 2 months ago

Data for the levees set two sides (grid 24959) to 897.3336 below the 936 m of WSE in this lesson, see below. The project domain gets completely inundated by the water release through this hole.

image

rpachaly commented 2 months ago

@FLO-2DKaren I'm working on this and trying to figure out the bug. The bug seems to be related to the moving window, again. I'm not pretty sure, but it seems that the center of each corner of the moving window is on the center of the grid. That's why usually some of the levees directions are problematic and others don't. I added an inner loop that gets all levees in a grid and it seems to have solved our problem without increasing significantly the computational time.

In my testing, the new code is better on the testing that I did on the self help kit and on the tailings dam project. However, the big wall tests the results are different, with the new code looking more correct. We need to figure out a good way of testing this.

I think in the future we will need to revisit and refactor this levee code, it is a bunch of small and weird adjustments.

I'll do a little bit more of testing before pushing the branch.

rpachaly commented 2 months ago

Ok, I did a bunch of testing and the new code is better and correct. It is merged on https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1539.

Check this comparison on the BigWallTest. The current code exports a lot of -9993 which is wrong. The modified code fixed that and it is exporting correctly for all the testing that I did. Karen, when you are doing your testing on this, please look for these negative values.

image

FLO-2DNoemi commented 2 months ago

Thanks, I just downloaded it.

On Wed, Sep 4, 2024 at 1:43 PM Robson Pachaly @.***> wrote:

Ok, I did a bunch of testing and the new code is better and correct. It is merged on #1539 https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1539.

Check this comparison on the BigWallTest. The current code exports a lot of -9993 which is wrong. The modified code fixed that and it is exporting correctly for all the testing that I did. Karen, when you are doing your testing on this, please look for these negative values.

image.png (view on web) https://github.com/user-attachments/assets/c2b93483-28d2-4c8b-a042-e0a46f166bf3

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1528#issuecomment-2329642796, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3QNDD2QNGKSHWVUCGDZU5BDHAVCNFSM6AAAAABNMKVEGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGY2DENZZGY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

FLO-2DKaren commented 2 months ago

Let's add a moving window checkbox. So you only use that method if you actually have large data.

FLO-2DKaren commented 2 months ago

@rpachaly Please watch this video with respect to the self help kit. I'm setting up the big wall test next. https://flo-2d.sharefile.com/d-s4f79d07aa8174c5fbb3ed8d16b27dad7

I wonder if one of the variables that's used to calculate elevation is coming from the schema layer instead of the user layer. We should study which of those variables are being used when it enters the second window. Maybe it's not the window code but the cleanup code that's causing this issue.

For example what if there was a catch all for missing data that used the schema data instead of the user data to finish the calculation. That would cause the levee crest to be doubled because it's not null in the schema layer but it still sees the coorection.

FLO-2DKaren commented 2 months ago

hmmm I did the big wall test and all of mine came out -9993.

FLO-2DKaren commented 2 months ago

image

FLO-2DKaren commented 2 months ago

Well good news. Because I didn't have elevation in my BigWall test, I was able to see the issue more clearly.

  1. Let's add a Clip Line Features to the Moving Window code when we process the line data. We can store the clip in a temp file and then throw it away.

There are now 3 videos to review.

FLO-2DKaren commented 1 month ago

Just a note that this issue is still open and valid.

FLO-2DNoemi commented 3 weeks ago

Is this fixed? I am still seeing this.

On Thu, Oct 17, 2024 at 12:44 PM Karen @.***> wrote:

Just a note that this issue is still open and valid.

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1528#issuecomment-2420025719, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3XCVHOWTTRPYLCPG23Z37SOZAVCNFSM6AAAAABNMKVEGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRQGAZDKNZRHE . You are receiving this because you commented.Message ID: @.***>

rpachaly commented 3 weeks ago

Hi all,

I have not received the latest comments on this issue, I don't know why. I'll work on this.