IFLO direction in the Floodplain Cross Sections

FLO-2DSoftware / qgis-flo-2d-plugin

A plugin for pre-processing/post-processing FLO-2D models

8 stars 8 forks source link

IFLO direction in the Floodplain Cross Sections #1529

Open rpachaly opened 2 months ago

rpachaly commented 2 months ago

setting the IFLO direction in the Floodplain Cross Sections can be difficult to understand. We could add a small sketch showing flow directions in a typical cell. Just thinking out loud, but this is something we should consider improving to make it clearer

rpachaly commented 2 months ago

@FLO-2DNoemi I added a tooltip into the Plugin following the DIM. See:

I tried to add an image to the tooltip, but it did not work. We can add this to the documentation and a brief explanation, what do you think @FLO-2DKaren?

rpachaly commented 2 months ago

The tooltip is done and merged on https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1530/files

FLO-2DKaren commented 2 months ago

Let's simplify the message. The negative values are rarely used.
This will make the box smaller.

<html><head/><body>Defines the general direction expected to cross the line. IFLO is set to one of the following:1 flow to the north2 flow to the east3 flow to the south4 flow to the west5 flow to the northeast6 flow to the southeast7 flow to the southwest8 flow to the northwest</body></html>

FLO-2DKaren commented 2 months ago

I just noticed something to improve this system.

[ ] The trigger is advancing to the next cross section when the direction is assigned. That is kind of confusing because you expect to see the edit you just made and instead you see the next cross section and it's different. Remove the advance trigger. Let the user advance the cross section themselves.
[ ] Cross sections can be assigned any direction but only two are valid. All other directions will result in a bad reported data. It will be invalid. Let's limit the flow directions based on the angle of the line.
[ ] When Schema button is ran, we need to close and save the edits instead of showing python error.

https://github.com/user-attachments/assets/62e361c8-ab9d-46c6-8a36-3c2b27c65214

FLO-2DKaren commented 1 month ago

@rpachaly Hi Robson, Before I close this. Can you please look into that trigger issue?