storm drain plots - Githubissues

FLO-2DKaren commented 1 month ago

Let's think of building our own plottting tools for storm drain results because swmmio is too slow.

FLO-2DNoemi commented 1 month ago

I completely agree with this. Not only because SWMMIO is slow but we need to see the surface results in the WSE plots. If we add surface WSE we will be able to analyse the surface SD interaction at each output timestep.

If I am not mistaken, the EPA SWMM GUI code is written in DELPHI (Embarcadero's Delphi 10.4). Code is attached, I downloaded it two weeks ago with this intention, we can try to see if this code helps us to develop our own tool. Just an idea.

On Mon, Oct 14, 2024 at 10:20 AM Karen @.***> wrote:

Let's think of building our own plottting tools for storm drain results because swmmio is too slow.

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1575, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3SWWIVG6WA6JHVT4QLZ3PHLPAVCNFSM6AAAAABP5D2DO6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4DMMJZG4ZTIOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rpachaly commented 3 weeks ago

Just to be clear, the swmmio is only used for plotting the profile view. All other plots using the results tool and the info tool were built by us.

FLO-2DKaren commented 3 weeks ago

I'm sorry Robson but this belongs on MapCrafter. I'm closing this issue here.

rpachaly commented 2 weeks ago

Let's reopen this, Karen. We can add the same process on the Info Tool and on the Results Tool. I'm working on creating such plots. Check this out:

download

This is what I can achieve without swmmio and using matplotlib. It is not required the swmm.rpt to create the profile, we only need the swmm.rpt to show the wse.

What do you think? It was not easy to do, specially to find the path, but it is doable. This was done outside QGIS in a jupyter notebook with a lot of data added by hand to see the final result.

rpachaly commented 2 weeks ago

I used chat gpt to convert the code to pyqtgraph. Here is the result:

So, we can use both libraries.

matplotlib:

Advantages: more user friendly, more robust, simpler code
Disadvantages: we need to create a window to show the plot

pyqtgraph:

Advantages: we can use the FLO-2D plot on the bottom bar without any issue
Disadvantages: less robust and hard to code

IMHO, we should stick with the pyqtgraph since we are already using this one and it will be easier to use this tool for review, even though it is a pain in the neck to code the pyqtgraphs.

rpachaly commented 2 weeks ago

@FLO-2DNoemi @FLO-2DKaren

Check this out!!

https://github.com/user-attachments/assets/8482e838-4186-4c70-bec3-428d0842a884

FLO-2DNoemi commented 2 weeks ago

Good Afternoon Robson,

It looks very good.

I would like to see the option to add maximum water surface elevation at each node. To do this, we will need additional data, like connectivity between junctions and surface grid elements, this will only be used for plotting.

Eventually, we need to add the animator including WSE from TIMDEP. This is not an easy task.

We can discuss other ideas at our next week's meeting.

Thanks,

N

On Wed, Nov 6, 2024 at 8:13 AM Robson Pachaly @.***> wrote:

@FLO-2DNoemi https://github.com/FLO-2DNoemi @FLO-2DKaren https://github.com/FLO-2DKaren

Check this out!!

https://github.com/user-attachments/assets/8482e838-4186-4c70-bec3-428d0842a884

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1575#issuecomment-2459720032, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3VYG7VGQK4HCGLMCHTZ7IIV5AVCNFSM6AAAAABP5D2DO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJZG4ZDAMBTGI . You are receiving this because you were mentioned.Message ID: @.***>

rpachaly commented 2 weeks ago

Hmm.. interesting. You mean plotting the FLO-2D Maximum Depth results from DEPTH.OUT along with the storm drain profile. That's a great idea. What if I add the TOPO.DAT as the FLO-2D terrain data? That will look nice.

FLO-2DNoemi commented 2 weeks ago

Yeah, that sounds good too.

On Wed, Nov 6, 2024 at 2:48 PM Robson Pachaly @.***> wrote:

Hmm.. interesting. You mean plotting the FLO-2D Maximum Depth results from DEPTH.OUT along with the storm drain profile. That's a great idea. What if I add the TOPO.DAT as the FLO-2D terrain data? That will look nice.

— Reply to this email directly, view it on GitHub https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/issues/1575#issuecomment-2460639756, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE32O3WLRTSNIZFUK7A2QI3Z7JXA5AVCNFSM6AAAAABP5D2DO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRQGYZTSNZVGY . You are receiving this because you were mentioned.Message ID: @.***>

rpachaly commented 2 weeks ago

Just to save this information in this issue: https://stackoverflow.com/questions/46325447/animated-interactive-plot-using-matplotlib/46327978#46327978

rpachaly commented 2 weeks ago

Here is the current state. Did a lot of fixes today and I added the FLO-2D Results.

Average Depth, HGL and Maximum Depth are from SWMM.RPT, FLO-2D Terrain from TOPO.DAT and FLO-2D WSE from MAXWSELEV.OUT.

Still need to work in minor stuff, but probably tomorrow I'll try to animate this.

rpachaly commented 1 week ago

Hi all,

The animator is almost ready. Please, take a look in this video: https://flo-2d.sharefile.com/d-s24256c7f9b8349c8b8cbc3635cd32a3b

rpachaly commented 1 week ago

Future implementations:

[ ] Add nodes names on secondary x axis
[ ] Convert the MAXWSE.OUT and TOPO.DAT to point instead of lines (decide on that)
[ ] Add the possibility to export the animation (may need an external library/software such FFMPEG)
[ ] Interaction between the surface WSE, and the PH
[ ] Print in red blow off manholes? (decide on that)

rpachaly commented 5 days ago

A first stable version was merged https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/pull/1589

FLO-2DSoftware / qgis-flo-2d-plugin

storm drain plots #1575