search

FLOIP / flow-results

Open specification for the exchange of "Results" data generated by mobile platforms using the "Flow" paradigm
6 stars 2 forks source link

Change api-data-url to api_data_url (Consistency with underscore convention in rest of spec; JS properties) #36

Closed markboots closed 3 years ago

markboots commented 3 years ago

To address #35 : Change api-data-url to api_data_url:

@pld @nditada , we discussed this one over email a few weeks ago. Any concerns on this change to resolve the one casing inconsistency in the spec, and make it easier to work with the api_data_url attribute as a JS property? Would you be able to implement this edit on your implementations?

markboots commented 3 years ago

@pld @nditada , let us know if you'd like more time to review/discuss this casing change? I imagine you're starting holidays, so let me know if you need more time. This is one spec change for Flow Results it would be great to get resolved ahead of more projects looking at FR in the context of the Phase 3 community RFA.

pld commented 3 years ago

I don’t have any strong opinions on this, I’m unaware if anyone is reliant on the current format.

@ukanga any comment on this?

On Dec 23, 2020, at 11:39 AM, Mark Boots notifications@github.com wrote:

@pld https://github.com/pld @nditada https://github.com/nditada , let us know if you'd like more time to review/discuss this casing change? I imagine you're starting holidays, so let me know if you need more time. This is one spec change for Flow Results it would be great to get resolved ahead of more projects looking at FR in the context of the Phase 3 community RFA.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FLOIP/flow-results/pull/36#issuecomment-750378838, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMESOZG7MVHGJQIS3EXDSWIMLNANCNFSM4U4VJOMQ.