FLUX-SE / PayumStripe

Payum Stripe gateways (with SCA support)
MIT License
28 stars 15 forks source link

Added configuration key for payment method types #16

Closed Vogeslu closed 3 years ago

Vogeslu commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #16 (c977d88) into master (2ffbcdb) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     99.80%   99.81%           
- Complexity      339      345    +6     
=========================================
  Files            89       89           
  Lines          1038     1053   +15     
=========================================
+ Hits           1036     1051   +15     
  Misses            2        2           
Impacted Files Coverage Δ Complexity Δ
src/AbstractStripeGatewayFactory.php 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...ion/StripeCheckoutSession/ConvertPaymentAction.php 100.00% <100.00%> (ø) 9.00 <1.00> (+1.00)
src/Api/Keys.php 100.00% <100.00%> (ø) 13.00 <5.00> (+5.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ffbcdb...c977d88. Read the comment docs.

Prometee commented 3 years ago

@Vogeslu sorry for the delay, thank you very much for this PR and I think you are the first one to keep the build green 🎉

The addition of :

if (false === $details->offsetExists('payment_method_types')) {
    $details->offsetSet('payment_method_types', ['card']);
}

was designed to be able to add this payment_method_types from the $payment->getDetails() array, but I understand that most of the time, this info have to be defined into the gateway config.