search

FLUX-SE / PayumStripe

Payum Stripe gateways (with SCA support)
MIT License
28 stars 15 forks source link

[Feature] Dedicated Api classes for each gateway factories #17

Closed Prometee closed 3 years ago

Prometee commented 3 years ago

The PR of @Vogeslu make me rethink how the Api/Key class have to be used and maybe have to be renamed. I'm thinking about getting dedicated Api classes for each gateway factories like this :

  1. StripeCheckoutSession :
    • FluxSE\PayumStripe\Api\StripeCheckoutSessionApi using traits :
      • FluxSE\PayumStripe\Api\KeysAwareTrait
      • FluxSE\PayumStripe\Api\AuthorizeApiAwareTrait Finally add getter/setter for payment_method_types or a dedicated trait
  2. StripeJs :
    • FluxSE\PayumStripe\Api\StripeJsApi extends FluxSE\PayumStripe\Api\AbstractStripeKeys using trait FluxSE\PayumStripe\Api\AuthorizeApiAwareTrait