FLUX-SE / PayumStripe

Payum Stripe gateways (with SCA support)
MIT License
28 stars 15 forks source link

Expire session instead of cancel payment intent #29

Closed Prometee closed 1 year ago

Prometee commented 1 year ago

Related issue #28

codecov[bot] commented 1 year ago

Codecov Report

Merging #29 (9a693eb) into master (48973d5) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     99.82%   99.83%           
- Complexity      408      411    +3     
=========================================
  Files           106      107    +1     
  Lines          1171     1182   +11     
=========================================
+ Hits           1169     1180   +11     
  Misses            2        2           
Impacted Files Coverage Δ
src/AbstractStripeGatewayFactory.php 100.00% <100.00%> (ø)
src/Action/Api/Resource/AllSessionAction.php 100.00% <100.00%> (ø)
...ripeCheckoutSession/AbstractCancelUrlExtension.php 100.00% <100.00%> (ø)
...tSession/CancelUrlCancelPaymentIntentExtension.php 100.00% <100.00%> (ø)
...outSession/CancelUrlCancelSetupIntentExtension.php 100.00% <100.00%> (ø)
...heckoutSession/CancelUrlExpireSessionExtension.php 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Prometee commented 1 year ago

@dragosprotung not tested yet but you can try it already (lunch time). Let me know if it fix your issue.

dragosprotung commented 1 year ago

@Prometee I will test it this evening and report back.

dragosprotung commented 1 year ago

@Prometee i tested and it seems to be working as expected !