FLUX-SE / PayumStripe

Payum Stripe gateways (with SCA support)
MIT License
28 stars 15 forks source link

Added CancelAction for CheckoutSession #30

Closed dragosprotung closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #30 (2c3937d) into master (92d3db8) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage     99.83%   99.83%           
- Complexity      416      425    +9     
=========================================
  Files           109      110    +1     
  Lines          1194     1218   +24     
=========================================
+ Hits           1192     1216   +24     
  Misses            2        2           
Impacted Files Coverage Δ
src/AbstractStripeGatewayFactory.php 100.00% <100.00%> (ø)
src/Action/CancelAction.php 100.00% <100.00%> (ø)
src/Action/StripeCheckoutSession/CancelAction.php 100.00% <100.00%> (ø)
src/StripeCheckoutSessionGatewayFactory.php 100.00% <100.00%> (ø)
src/StripeJsGatewayFactory.php 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

dragosprotung commented 1 year ago

@Prometee I added all the tests and for now I think it's a good compromise for testing the configuration. Please let me know if more things should be tested

Prometee commented 1 year ago

@dragosprotung I like how you manage to test the override of gateway config, it is very clear and will prevent errors in the futur.

dragosprotung commented 1 year ago

@Prometee any reason to wait for merging this ?

Prometee commented 1 year ago

@dragosprotung sorry for the delay I'm sick since Saturday and wanted to test it with my real world test app. But I can already merge it and test it later during my PR

dragosprotung commented 1 year ago

Thank you. Get well soon !