FLUX-SE / PayumStripe

Payum Stripe gateways (with SCA support)
MIT License
28 stars 15 forks source link

Working StripeJs Integration #5

Closed odiseoteam closed 3 years ago

odiseoteam commented 3 years ago

Hi @Prometee @jordisala1991 could you check this? At the moment I don't have the enough time to finish the PR by myself.

codecov[bot] commented 3 years ago

Codecov Report

Merging #5 into master will decrease coverage by 0.12%. The diff coverage is 99.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #5      +/-   ##
============================================
- Coverage     99.85%   99.72%   -0.13%     
- Complexity      224      242      +18     
============================================
  Files            53       60       +7     
  Lines           672      736      +64     
============================================
+ Hits            671      734      +63     
- Misses            1        2       +1     
Impacted Files Coverage Δ Complexity Δ
src/Action/JsCaptureAction.php 90.90% <90.90%> (ø) 3.00 <3.00> (?)
src/AbstractStripeGatewayFactory.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/Action/Api/PayAction.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
.../Action/Api/Resource/CreatePaymentIntentAction.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
.../Action/Api/Resource/CreatePaymentMethodAction.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/Action/CaptureAction.php 100.00% <100.00%> (ø) 16.00 <6.00> (+2.00)
src/Request/Api/Pay.php 100.00% <100.00%> (ø) 6.00 <6.00> (?)
src/StripeCheckoutSessionGatewayFactory.php 100.00% <100.00%> (ø) 1.00 <0.00> (-2.00)
src/StripeJsGatewayFactory.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 909f7ca...9b830e3. Read the comment docs.

Prometee commented 3 years ago

Thanks you @odiseoteam 🎉

While making the doc for this gateway I will build a exemple to really test it with Stripe test credentials.

odiseoteam commented 3 years ago

you're welcome @Prometee , glad to see that this library have support for StripeJs now.