VIES Soap validation not happening

FLUX-SE / SyliusEUVatPlugin

This Sylius Plugin allow you to add European VAT Number to the addresses and manage European VAT number rule

MIT License

16 stars 8 forks source link

VIES Soap validation not happening #28

Closed gabiudrescu closed 4 years ago

gabiudrescu commented 4 years ago

In the readme you are advertising VIES API validation - but I can't seem to find anything related to this in the source code.

Prometee commented 4 years ago

@gabiudrescu it's because the validation is not done in this plugin, but in the dependent bundle : https://github.com/Prometee/VIESClientBundle also dependending on a lib https://github.com/Prometee/VIESClient

gabiudrescu commented 4 years ago

@Prometee so, with this file https://github.com/Prometee/SyliusVIESClientPlugin/blob/master/src/Resources/config/validation/VATNumberAwareInterface.xml#L14 you are calling this class https://github.com/Prometee/VIESClientBundle/blob/master/Constraints/VatNumberValidator.php#L38 that is using this helper to call the soap ws: https://github.com/Prometee/VIESClient/blob/master/src/Helper/ViesHelper.php#L38

Prometee commented 4 years ago

Yes this is how it works because VIES webservice could be used elsewhere (other sf projects, raw php project, etc...) and I like to separate things which can be separated

gabiudrescu commented 4 years ago

thanks for the info.