FLVC / flvc

FLVC-specific Islandora Hooks
0 stars 2 forks source link

Islandora to Encore: Moving from permanently delete to status Deleted: Items with status Deleted show up from the collection "Manage" tab of the collection they are in #63

Closed wrandtkeflvc closed 5 years ago

wrandtkeflvc commented 7 years ago

On islandora-dev, when I delete an object, I can still see the object from some roles where I shouldn't be able to see it.

When an object is deleted, it still shows up here: browse to collection that item was in, click the "Manage" tab, click to "Collection", click to "Share members" or "Migrate members" or "Delete members of this collection". From those areas, you will still see the deleted items.

This is true for these roles:

I am also able to directly get to the object by URL from any of those roles and click through actions on the object.

Here is the desired behavior: The deleted object should not be seen from the collection "Manage" tab.

wrandtkeflvc commented 7 years ago

This is now open at CRM case no. CAS-87470-F4Z5 https://flvc.crm.dynamics.com:443/main.aspx?etc=112&id=4b393968-5592-e711-8110-5065f38b3191&histKey=676477537&newWindow=true&pagetype=entityrecord .

wrandtkeflvc commented 5 years ago

This fix was moved to production March 8, 2018.

From: Lydia Motyka Sent: Friday, January 12, 2018 12:57 PM To: Gail Lewis; Wilhelmina Randtke Subject: RE: Ignorant delete functionality question

Gail,

Is the delete code on the test server as well? It’s difficult to test by site on the DEV server, although if you say it doesn’t limit by site I guess there’s not much testing to be done. My initial take is that it would make the users more independent if they had control over their deleted objects. Logically and conceptually there’s no reason that site admins or even collection admins shouldn’t be able to “undelete” objects. Less support time for us if they’re more independent. Could be a Phase 2 thing, if it’s a lot of work. I don’t think we get a lot of requests to “undelete” objects anyway, and when we do I think that they’ve been pretty large requests.

Lydia

From: Gail Lewis Sent: Friday, January 12, 2018 11:44 AM To: Lydia Motyka LMotyka@flvc.org; Wilhelmina Randtke WRandtke@flvc.org Subject: RE: Ignorant delete functionality question

I noticed yesterday that Manage Deleted Objects does not limit by site. If our intention is to only allow access to administrator, we could leave it as is, but it may be better to limit it by site. Let me know what you think.

Note that from this list, you can “restore selected objects” but the option to “irrevocably purge selected objects” will not work, because it’s going through Islandora. We might consider modifying the underlying code to call Randy’s delete script to enable a true purge from here.

Gail

From: Lydia Motyka Sent: Friday, January 12, 2018 11:37 AM To: Gail Lewis GLewis@flvc.org; Wilhelmina Randtke WRandtke@flvc.org Subject: RE: Ignorant delete functionality question

That’s good, because that’s what it’s doing.

Thanks,

Lydia

From: Gail Lewis Sent: Friday, January 12, 2018 11:31 AM To: Lydia Motyka LMotyka@flvc.org; Wilhelmina Randtke WRandtke@flvc.org Subject: RE: Ignorant delete functionality question

Any delete function through Islandora is intercepted and instead sets the state to delete. We didn’t change the wording for delete requests so it does read as confusing. With this change in place, the only ways to truly remove an object from the repository is from the command line (Randy’s script) or through some other interface like the Fedora admin interface.

Gail

From: Lydia Motyka Sent: Friday, January 12, 2018 11:26 AM To: Gail Lewis GLewis@flvc.org; Wilhelmina Randtke WRandtke@flvc.org Subject: Ignorant delete functionality question

I’m starting to test the changes in delete functionality on dev, and I have one very basic question: Has the functionality changed behind the Properties -> Permanently remove .. from repository link changed, or does that still permanently delete objects and another delete method needs to be used to make objects status deleted? My recollection is that the functionality behind “Permanently remove…” has changed, but my memory on this may be faulty.

It’s been a long time since I’ve thought about this, so I want to be certain that I’ve got the fundamentals right.

Thanks,