search

FLVC / flvc

FLVC-specific Islandora Hooks
0 stars 2 forks source link

Full MODS form opening PURL as "Not a PURL" #69

Closed wrandtkeflvc closed 6 months ago

wrandtkeflvc commented 7 years ago

This is regarding the <location displayLabel="purl"><url> field in MODS.

The Full MODS form has a bug to where when it is used to open a PURL, it will flip the value to "Not a PURL".

MODS Simple Entry and Full MODS handle locDispLabel differently. It looks like this was changed sometime between when Priscilla Caplan shared a version of the Full MODS form on a listserv in March 2014 and when Mike Demers installed the Full MODS form in November 2015.

Since MODS Simple Entry is handling this field correctly, it's good to look at this different and get Full MODS form to where it's handling things more like MODS Simple Entry.

wrandtkeflvc commented 7 years ago

This is CRM case no. CAS-89090-M0H2 https://flvc.crm.dynamics.com/main.aspx?etc=112&id=760333d9-86b9-e711-8118-5065f38a4961&histKey=161432931&newWindow=true&pagetype=entityrecord

wrandtkeflvc commented 6 years ago

Looked into this. The form doesn't flip the PURL to not-a-PURL unless the person mixes in a PURL with physical location info. Because of how the form looks (ie. usability and labeling of form fields), some workers have done that - commingled PURL and physical location info.

The ideal way to handle this is to make 2 separate fields - one for PURL and one for physical location and URL, and have those fields totally separate, and that way a person using the forms to edit metadata won't be able to mix up the fields.

Not sure about doing a metadata cleanup. I think for this one, that the way to do that is give a report of affected objects, and then give a short custom form that lets the person just hit their few objects.

wrandtkeflvc commented 5 years ago

A fix for this is posted to https://github.com/wrandtkeflvc/XSLTsForFloridaIslandora/blob/master/SequenceSubElementsWithinLocation.xsl .

Would need to validate MODS on the server on the back end, then run that stylesheet over things.

And... also add that snippet to the stylesheet that works when the form saves.

Meanwhile, Diego has a good fix for this to apply to the stylesheet that runs when the form saves metadata : https://github.com/Islandora/islandora_xml_forms/pull/231/files#diff-ac93f11d810b7db89806d21637387ca8 .