search

FM-17 / poglink

A bot that integrates the ARK Web API with Discord.
MIT License
12 stars 4 forks source link

Aim for full test coverage #54

Open travipross opened 2 years ago

travipross commented 2 years ago

Now that Codecov has been introduced to CI in #52 , the test coverage is easily visible. We should aim for 100% coverage wherever possible, as we're already quite close.

There may need to be a file or two ignored from coverage reports where it doesn't seem reasonable to test (e.g. a while: True loop in the main process).

travipross commented 2 years ago

@FM-17 I forgot to link this issue to my last PR (#57).

Should we continue trying to tweak to get that last few percent coverage? I'm happy to leave this issue open, or to just close it and continuously increment test coverage on future PRs as a matter of habit.

Should I omit the bans cog until we've properly built and tested it? I get the impression that it's kind of extra, unusued code right now.

travipross commented 10 months ago

Would recommend no longer aiming for full test coverage. 80/20 rule should apply here; We have high coverage and should be less focused on the final few percent but instead on making sure core functionality is tested.

Proposing to close.