FM-17 / poglink

A bot that integrates the ARK Web API with Discord.
MIT License
12 stars 4 forks source link

feat: parsing for new pve/pvp atlas urls #71

Closed FM-17 closed 1 year ago

FM-17 commented 1 year ago

Hotfix to account for the division of ATLAS endpoints

New endpoints are PVE: http://atlasdedicated.com/atlas-eu-pve/dynamicconfig.ini PVP: http://atlasdedicated.com/dynamicconfig.ini

Ideally, this should be updated later to just accept a custom endpoint-title pair, that way we don't have to parse the DEFAULT_SERVER_INFO dict or do any regex matching for custom scenarios like this.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: -1.10 :warning:

Comparison is base (866bc8e) 92.83% compared to head (6ba81e6) 91.74%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #71 +/- ## ========================================== - Coverage 92.83% 91.74% -1.10% ========================================== Files 10 10 Lines 405 412 +7 ========================================== + Hits 376 378 +2 - Misses 29 34 +5 ``` | [Impacted Files](https://codecov.io/gh/FM-17/poglink/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [poglink/cogs/rates.py](https://codecov.io/gh/FM-17/poglink/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cG9nbGluay9jb2dzL3JhdGVzLnB5) | `93.39% <66.66%> (-4.59%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 0.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: