search

FMCorz / AclManager

Plugin to manage Acl for CakePHP 2.x
59 stars 33 forks source link

Added elements to remove some hardcoded primaryKey field name #19

Open tranfuga25s opened 10 years ago

tranfuga25s commented 10 years ago

This pull request helps in the situations where the ACO object's do not have "id" has primaryKey field. See issue #18

FMCorz commented 10 years ago

Thanks for the pull request.

1/ Could you clean your patch not to fix all those whitespace issues? Ideally this should take place in another pull request as it could create unnecessary conflicts with other patches, and is not the right place to fix it.

2/ You are adding another $inherit = in the view rather than fixing the existing one.

3/ Indentation issue when setting aroPk to the view.

Many thanks! Fred