search

FMCorz / mdk

Moodle Development Kit. A collection of tools meant to make developers' lives easier.
GNU General Public License v3.0
85 stars 47 forks source link

Use example.com for email addresses #123

Closed xow closed 8 years ago

xow commented 8 years ago

I occasionally get weird problems when using the mdk generated accounts because their emails do not validate correctly. Example.com was created for this purpose. Alternatively perhaps we could use @test.moodle.org

I understand if it's better to use localhost for the sake of email debugging. Personally I use mailcatcher which catches all outbound emails, so sending them off to example.com isn't a problem for me. Just making this patch to throw the idea out there.

FMCorz commented 8 years ago

I have been thinking about that too, and I wanted to set the domain to the domain referenced in mdk config show host, however it's not clean to get that host from mdk when running a script.

FMCorz commented 8 years ago

Cheers!

danpoltawski commented 8 years ago

+1 for this change, I prefer this to using the host anyway.