search

FMCorz / mdk

Moodle Development Kit. A collection of tools meant to make developers' lives easier.
GNU General Public License v3.0
85 stars 47 forks source link

Add support for grunt css from 29 onwards #130

Closed andrewnicols closed 8 years ago

FMCorz commented 8 years ago

I like the patch, that's so cool that we've got a Compiler base class. Just a question though, does grunt support the flags compress and debug? If not, maybe we could keep a fallback on another compiler when those are set.

andrewnicols commented 8 years ago

Hi Fred,

It compresses by default and there is no flag to turn that off in grunt at this time.

At the moment, this patch already handles --debug (our gruntfile doesn't do anything interesting --debug). When --debug is set we already use LessC, and set the Compress Flag. There is no other way of setting the compress flag - it's only called when running --debug.

FMCorz commented 8 years ago

Thanks for the details, and the patch :dancer: !

danpoltawski commented 8 years ago

I'm reading this patch and it looks kind of wrong to me? The grunt css command only handles moodle bootstrapbase sheets and not any random sheet passed - where as compiler = Grunt(source, os.path.join(source, sheet), os.path.join(dest, destSheet)) gives the impression it'll compile those sheets?