Tidy up the version script

FMCorz / mdk

Moodle Development Kit. A collection of tools meant to make developers' lives easier.

GNU General Public License v3.0

85 stars 47 forks source link

Closed andrewnicols closed 6 years ago

FMCorz commented 8 years ago

Thanks Andrew. Can you describe the added value of your changes?

FMCorz commented 6 years ago

I (finally) noticed the use of a constant over hardcoded string and thought it was valuable. Thanks!

FMCorz commented 6 years ago

Noticed too late, but it might be better to stick with the set_config rather than the call $DB. Thoughts?

andrewnicols commented 6 years ago

Ah - good thought. I can't recall why I did that so probably better to switch back. Sorry I missed your comment 2 years ago!