search

FMCorz / mdk

Moodle Development Kit. A collection of tools meant to make developers' lives easier.
GNU General Public License v3.0
85 stars 47 forks source link

MDK doctor --fix --all points the origin of integration instances to moodle.git after running mdk run setupsecurity #164

Open junpataleta opened 6 years ago

junpataleta commented 6 years ago

To reproduce:

  1. Create and install an integration instance.
  2. Run mdk run setupsecurity
  3. Run mdk doctor --fix --all
  4. Run git remote -vv
    • Origin now points to ~/.moodle-sdk/moodle.git
dmonllao commented 6 years ago

Hi Jun, we don't flag the instance as a security instance just add a hook and use security.git as origin. I don't know much about mdk but a possible solution would be to respect that origin can be set to mdk config show remotes.security in https://github.com/FMCorz/mdk/blob/master/mdk/commands/doctor.py#L222 and https://github.com/FMCorz/mdk/blob/master/mdk/commands/doctor.py#L228