search

FMCorz / mdk

Moodle Development Kit. A collection of tools meant to make developers' lives easier.
GNU General Public License v3.0
85 stars 47 forks source link

Warn the user if the keyring module can't be loaded #166

Closed mudrd8mz closed 6 years ago

mudrd8mz commented 6 years ago

From time to time I am running into troubles with my local keyring installation. I am not sure what was the original intention but I think it is valid to warn the user if the keyring module can't be loaded - especially given it is enlisted among requirements.

mudrd8mz commented 6 years ago

Thanks @scara I've amended the patch.

FMCorz commented 6 years ago

The original intention was to support the usage of the jira module without requiring the keyring module, and not pollute the console with a redundant message when the module wasn't desired. That predates the requirements.txt file which now includes all the required dependencies for MDK to work properly. The keyring module should not be missing when MDK is installed properly.

A better way of doing this could be to add a check to mdk doctor, which I thought I added, but probably ran into issues as MDK wouldn't load at all when dependencies are missing. At some point, we should be migrating towards pipenv for dependency management.

Merged, thanks.