Make mdk precheck work again

[mudrd8mz]

After a recent upgrade of HQ CI Jenkins, the mdk precheck stopped working.

[mudrd8mz]

I don't know what other steps are needed with regards to jenkinsapi version bump. On my machine, I just ran pip install --user -r requirements.txt. Leaving the proper packaging part of more experienced ones.

Related readings:

• https://wiki.jenkins.io/display/JENKINS/CSRF+Protection
• https://wiki.jenkins.io/display/JENKINS/Remote+access+API#RemoteaccessAPI-CSRFProtection
• https://thepracticalsysadmin.com/fix-the-jenkinsapi-no-valid-crumb-error/

[andrewnicols]

I think that this will be fixed in Jenkins shortly anyway: https://issues.jenkins-ci.org/browse/JENKINS-22474

That change landed in the LTS this week, and has already been applied to https://ci.moodle.org. I imagine that we'll soon be applying it to https://integration.moodle.org too.

[mudrd8mz]

I see. Thanks @andrewnicols

[mudrd8mz]

Any news on whether the JENKINS-22474 is already available on https://integration.moodle.org ? TIA

[stronk7]

Hi,

https://integration.moodle.org is running latest 2.114 and https://ci.moodle.org 2.107.1 (LTS) so it should be fixed in both sites. Prechecker is still in the former, of course. Soon will be moved.

So I'd say you can try this right now. Ciao :-)

[mudrd8mz]

Hmm, weird. I am still getting

Invoking the build on the CI server...
CIException: Failed to invoke the build, check your permissions.

like before.

[mudrd8mz]

And I can confirm that with this pull requested version, mdk precheck works for me.

[andrewnicols]

Ah well. So much for that bug being fixed. @FMCorz Can we pull this? :)

[FMCorz]

Thanks guys!

Note, the version of the jenkinsapi in requirements.txt was previously hard set (==) because they broke their API from one minor version to another, so I had it locked where it worked.