Improve version.php script (do not prompt for upgrade after running it)

FMCorz / mdk

Moodle Development Kit. A collection of tools meant to make developers' lives easier.

GNU General Public License v3.0

86 stars 47 forks source link

Improve version.php script (do not prompt for upgrade after running it) #189

Open marinaglancy opened 4 years ago

marinaglancy commented 4 years ago

do not accidentally bump the core version up
if we downgraded any plugins or core and moodle does not need upgrade, update the verison hash This way we won't need to run upgrade script after fixing version

FMCorz commented 4 years ago

Thanks Marina.

Have you considered simply running:

mdk run version; mdk upgrade --no-checkout

marinaglancy commented 4 years ago

I run this script on non-mdk installations so it was convenient for me if it does everything out-of-the-box. But if you think it's not needed, ignore this pull request

marinaglancy commented 4 years ago

also my change to line 33 was a bug imho