search

FMCorz / mdk

Moodle Development Kit. A collection of tools meant to make developers' lives easier.
GNU General Public License v3.0
84 stars 47 forks source link

TypeError when downloading patch file - Python 3.7.3 #195

Closed snake closed 4 years ago

snake commented 4 years ago

Using "mdk pull ISSUE_NUM" try to pull a patch file from a security issue. When prompted, select the number of the patch file. See the error: "TypeError: write() argument must be str, not bytes"

FMCorz commented 4 years ago

Probably related to the switch to Python 3, I imagine this is the incriminating line: https://github.com/FMCorz/mdk/blob/3fa84c41dbdde0c08d1e8d152ffd929f73c8548e/mdk/jira.py#L112

FMCorz commented 4 years ago

Never mind, did not notice the pull request.