search

FMCorz / mdk

Moodle Development Kit. A collection of tools meant to make developers' lives easier.
GNU General Public License v3.0
84 stars 47 forks source link

mdk-precheck does not handle integration.moodle.org response well #197

Open mudrd8mz opened 3 years ago

mudrd8mz commented 3 years ago

In the past, when running mdk precheck, it was waiting for the response and printed result.

It stopped working at some moment. I can't recall if it was when we moved to Python 3 or due to some change in Jenkins. But it now fails with:

$ mdk precheck Invoking the build on the CI server... ConnectionError: HTTPSConnectionPool(host='integration.moodle.org', port=443): Max retries exceeded with url: /queue/item/2002395/api/python (Caused by ProtocolError('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')))

The job itself is created and can be checked in Jenkins. But it was more convenient to get results printed by mdk itself.

danpoltawski commented 3 years ago

Could it be intermediary ssl certificates?

mudrd8mz commented 3 years ago

I just found in Telegram logs that it happened first to me on 19 February 2020. Sara replied to me that

It worked yesterday for me (although some times I have to launch it several times until it's executed)

https://t.me/c/1362398657/3498

mudrd8mz commented 3 years ago

And on 18 February, the mdk 2.0.0 was released - https://github.com/FMCorz/mdk/releases/tag/v2.0.0

So I suspect this to be a regression of that upgrade (which also was Python 3 IIRC).