Add support for optional wording.prefixDbname setting

[mudrd8mz]

Currently, the default database name is the same as the Moodle instance's name. This is suboptimal for development setups where the database engine is used for other projects as well (Moodle developer can easily have Mahara or Mediawiki databases present as well, for example).

I believe it's a good idea to make it clear that certain database is under mdk's control. Having a prefix (such as mdk_) seems to work well.

[FMCorz]

Hi David,

thanks for that, I had never thought that this could be an issue. Just 2 comments here:

• Add the default value (empty string) to the config-dist.json file
• I think the config would be better placed under 'db' rather than 'wording'. Wording is an obscure set, but I think in my mind it was related to what the user can "see"... What do you think about 'db.prefix' with a little comment explaining what this is responsible for,

Cheers, Fred

[mudrd8mz]

I agree it would fit the db.* set better. I saw other wording.prefix* settings there that seemed to be used for similar cases, so I picked it. Also, I was worried that having it in db.* could be a bit confusing as users could intuitively expect it's something related to $CFG->prefix (table name prefix). Maybe db.dbNamePrefix or db.namePrefix would work better? I'm happy to repatch once we agree here.

[FMCorz]

db.namePrefix sounds good to me, with a little comment saying that this affects the database names, not the tables.

[FMCorz]

(Misclicked, sorry)

[mudrd8mz]

Commit amended, please re-review and eventually pull if happy.

[FMCorz]

Thanks David, this is will be merged.