search

FMCorz / moodle-block_xp

A gamification plugin for Moodle allowing students to gain experience points and level up.
https://levelup.plus/?ref=github
149 stars 41 forks source link

Extract method refactor in filter->match() #63

Closed Canx closed 7 years ago

Canx commented 7 years ago

I will start with simple refactors like this... don't know if it's too small or is ok.

FMCorz commented 7 years ago

I find this kind of pull request to be too small. Ideally you'd want to do that as you're changing a functionality directly associated with it. Were you going to change the behaviour of "get_rule"? If not, I'm not sure I understand why this is needed in its current form.

Canx commented 7 years ago

ok, closing.