FMCorz / moodle-block_xp

A gamification plugin for Moodle allowing students to gain experience points and level up.
https://levelup.plus/?ref=github
150 stars 41 forks source link

Add multilanguage support to title and introduction #97

Closed dasistwas closed 5 years ago

dasistwas commented 5 years ago

This commit fixes https://github.com/FMCorz/moodle-block_xp/issues/96

I would be happy if you could merge.

Kind regards, David

FMCorz commented 5 years ago

Hi David,

Thanks for catching this, and submitting a patch. I have two minor comments:

format_string($text, true, ['context' => $world->get_context()]);

Would you be able to update your patch accordingly?

Thanks again! Fred

dasistwas commented 5 years ago

Hi Fred,

thank you for your detailed feedback. I just amended the changes in order to include the context in format_string and replaced the format_text. I am looking forward to your feedback and wish you a good weekend.

Kind regards, David

FMCorz commented 5 years ago

Thank you David! Your patch has been merged.