Closed dasistwas closed 5 years ago
Hi David,
Thanks for catching this, and submitting a patch. I have two minor comments:
format_string
as the description may not contain HTML.format_string
function should be called with the context associated with the $world
.format_string($text, true, ['context' => $world->get_context()]);
Would you be able to update your patch accordingly?
Thanks again! Fred
Hi Fred,
thank you for your detailed feedback. I just amended the changes in order to include the context in format_string and replaced the format_text. I am looking forward to your feedback and wish you a good weekend.
Kind regards, David
Thank you David! Your patch has been merged.
This commit fixes https://github.com/FMCorz/moodle-block_xp/issues/96
I would be happy if you could merge.
Kind regards, David