FMSC-Measurements / CruiseProcessing

2 stars 1 forks source link

Rounding of secondary logs in net volume calculations #32

Open BenCamps opened 5 months ago

BenCamps commented 5 months ago

There is a odd behavior when rounding logs in the net volume calculations. With secondary logs, .5 is added to the number of secondary logs and then the value is rounded. The intention here seems to be to round the number of secondary logs up if there is any fractional logs. However since default rounding behavior is to round to nearest even number, this might be adding an addental log in some cases.

https://github.com/FMSC-Measurements/CruiseProcessing/blob/6348d341c36aa725eea7b026f8db8eaf6aefeefe/src/CruiseProcessing.Core/CalculateNetVolume.cs#L50