FMSC-Measurements / CruiseProcessing

2 stars 1 forks source link

Confusing warning message when tree calculated values has neg/gross primary biomass of 0 #52

Open BenCamps opened 2 months ago

BenCamps commented 2 months ago

When summing up gross and net primary biomass when UOM is 05 there is a warning check to see if the values are 0. If they are it adds the following warning on Tree Calculated Values "BIOMASS FLAG NOT CHECKED -- NO WEIGHT CALCULATED"

This error can be confusing on for two reasons: It doesn't identify what tree the warning is originating from, and it isn't saying what it actually is checking and assuming that calcBiomass wasn't checked.

see: https://github.com/FMSC-Measurements/CruiseProcessing/blob/d6a735d2c0a2397b6a40f959f8ee4b9a9714ee95/src/CruiseProcessing.Core/SumAll.cs#L511

https://github.com/FMSC-Measurements/CruiseProcessing/blob/d6a735d2c0a2397b6a40f959f8ee4b9a9714ee95/src/CruiseProcessing.Core/SumAll.cs#L843