search

FMaz008 / VineHelper

Browser extension to improve Vine Experience
https://www.vinehelper.ovh
MIT License
32 stars 23 forks source link

Search functionality does not work on amazon.de #120

Open Wladefant opened 1 month ago

Wladefant commented 1 month ago

On amazon.de and many other countries the search functionality does not work, that is why the search button does not work. image

I would propose either removing it for these countries, or if someone can find a way to find it so that i can buy the product that would be awesome.

If nothing works, my proposal would be to at least save the location (category>subcategory>page) in a note.

FMaz008 commented 1 month ago

I just assumed the features using those links would not be useful and would get deactivated entirely.

Do you see a use for the pinned tabs without a search link?

I'm also curious to know how you the notifications (if you do).

Wladefant commented 1 month ago

Pin definitely, as the alternative would be to just loose the product. So with Pin I can remember which products I can buy in the future and I will have to go through the tedious job of finding it manually. Same goes for the notification feature by the way.

So the most achievable and easiest version would be to save the location of the product. As I mentioned above. I can try to implement it in the near future.

Do you know whether search will be implemented in other countries too. Did amazon give a sign for that?

FMaz008 commented 1 month ago

I have no idea if search will be added to new countries. Amazon does not share their plans with me :( But you could have people from your country fill the feedback form to request the feature to be added given it is already available in other countries (At least US and Canada that I know for sure)

But back to the topic of this ticket, it would be good to add some type of awareness of what item is in what category in Vine Helper. At the moment Vine Helper only deal with ASIN and, in part, queues, but has no implemented concept of categories.

Regarding the PR, keep in mind that the pinned items, when the remote storage is enabled, will be saved on the server, so there could be an issue if the category is only stored locally. For now it would be acceptable to just store the info locally and if it's not set (in the case of remote stored items), simply not display anything.

I was thinking of adding an option (default true) to display the search icon, so this way you could disable it.

FMaz008 commented 1 week ago

So instead of disabling the search icon, I've been working on a feature as an alternative to the search feature/page where it would try to open the modal window directly (in a new tab still). This should be available as an experimental feature for the upcoming v2.9, probably next month or so.

09ce313677e79651f6ee7f960a13d52647ca7228