search

FMaz008 / VineHelper

Browser extension to improve Vine Experience
https://www.vinehelper.ovh
MIT License
32 stars 23 forks source link

Rendering performance seems much worse - 2.4.10 #82

Closed skotl closed 5 months ago

skotl commented 5 months ago

Just as of this morning, VH seems to be struggling a bit. Debug shows 2208ms to final render, which isn't a massive concern of course but seems slower visually than it has been before.

I closed the single browser that is running on the machine and opened anew and performance is the same.

Just a concern if anything has changed rendering wise, or if there could be issues at the remote storage?

Thanks again for a great tool!

skotl commented 5 months ago

Hmmm.... watching it again it seems to go through multiple renders of the list (this is a screen with 36 hidden items). Has the rendering process changed? Looks like around 4 refreshes per page.

FMaz008 commented 5 months ago

So the timer start as soon as the DOM start loading and process the PREBOOT stuff (loading settings, etc).

But a lot of the actions (BOOT, etc) need to wait for the DOM to be done loading .

The list should only be processed once.

Can you post your debug log so I can see what you are refering to?

FMaz008 commented 5 months ago

And no, the rendering process has not changed for a while now... that's why I'm curious to see your debug log

skotl commented 5 months ago

log.txt

Here you go

FMaz008 commented 5 months ago

So the DOM is done loading at 919ms, which is when the extension can begin altering elements on the page (and before external elements are done loading).

At 1735ms the extension is done updating the page. So it took 816ms to activate the extension.

Those numbers are really good. Can you clarify what part seems slow?

FMaz008 commented 5 months ago

Could this be related too the high CPU usage bug that was reported ? Seems to be an issue with people using a lot of tabs.

skotl commented 5 months ago

Apologies for the delay in responding - been trying to figure out whether I'm imagining it or not. I use an I7 laptop and a desktop with a Ryzen 7 5700. Zero problems with the desktop but the laptop, which should be relatively fast, is definitely showing that weird multi-render view. It seems most pronounced in an AI view with all items hidden. I'll grab a video screen grab and post it.

skotl commented 5 months ago

Here's a link to the video.

I start on page one of AI and go to page 2, which has a handful of hidden items, then return to page one where everything is hidden. You should be able to see the multiple renders that I mentioned.

It's not a massive pain, just a bid odd...

https://youtu.be/1OebtIhYyKs

FMaz008 commented 5 months ago

Thabks for the video, it really help me understand the problem. This issue has nothing to do with the high cpu usage one. (Might be a high cpu issue, but not the same problem)

Do you have a particularily slow computer or any clue as to what the bottle neck might be?

What's your browser?

skotl commented 5 months ago

It certainly shouldn't be slow. It is a laptop, but it's a Dell 7390 with an i7-8650U and 16GB RAM. When I recorded the video that was immediately after a reboot with no other apps or browser tabs open.

Browser is Edge v2420.81 on Windows 11

For comparison, this desktop is a Ryzen 7 5700X - both machines share the GUID so should view the same data - and it's lightning fast here. Interestingly, this browser is Edge v2420.65 so a bit older.

crysallis commented 5 months ago

I noticed the address bar and plugins are mostly excluded from your video do you have any scripting type plugins extensions like noscript, adguard, Bitdefender etc.. or anything like that installed... that would be trying to interject itself Into the page rendering steps... what is the extension that is counting while the page is loading? I see what looks like noscript but potentially disabled, too low res to tell?

On Sat, Apr 6, 2024, 5:24 PM Scott Leckie @.***> wrote:

It certainly shouldn't be slow. It is a laptop, but it's a Dell 7390 with an i7-8650U and 16GB RAM. When I recorded the video that was immediately after a reboot with no other apps or browser tabs open.

Browser is Edge v2420.81 on Windows 11

For comparison, this desktop is a Ryzen 7 5700X - both machines share the GUID so should view the same data - and it's lightning fast here. Interestingly, this browser is Edge v2420.65 so a bit older.

— Reply to this email directly, view it on GitHub https://github.com/FMaz008/VineHelper/issues/82#issuecomment-2041208937, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG5LZ56STPWGVEM4DRDVE3Y4BR2JAVCNFSM6AAAAABFOICB36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGIYDQOJTG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

skotl commented 5 months ago

Good shout (and apologies for the blurring - there's a fair amount of dox material in my favourites bar!). Very good spot on the NoScript icon!

Yes - both machines share a login and share the same Edge extensions list:

Thanks again!

skotl commented 5 months ago

Huh... just seen what you mean by "what is the extension that is counting while the page is loading?" That's ublock origin

I just disabled it on the laptop (the one with slowish performance) and it makes no difference - still behaves as per the video

crysallis commented 5 months ago

Could you do a speedtest... google's is fine on both? is there a noticeable difference? Is one wired vs wireless? If both systems are using edge and both have the same extensions installed...and it works well in one but not the other... it can't be the extension... there has to be something different on the laptop vs the desktop.

On Sat, Apr 6, 2024 at 6:06 PM Scott Leckie @.***> wrote:

Huh... just seen what you mean by "what is the extension that is counting while the page is loading?" That's ublock origin

I just disabled it on the laptop (the one with slowish performance) and it makes no difference - still behaves as per the video

— Reply to this email directly, view it on GitHub https://github.com/FMaz008/VineHelper/issues/82#issuecomment-2041217209, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG5LZ7ULYZGFSLQQ2APRITY4BWXXAVCNFSM6AAAAABFOICB36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGIYTOMRQHE . You are receiving this because you commented.Message ID: @.***>

-- Daniel Peel

crysallis commented 5 months ago

and no worries, of course, on blurring that data lol... I just wanted to understand the environment!

On Sat, Apr 6, 2024 at 7:19 PM Daniel Peel @.***> wrote:

Could you do a speedtest... google's is fine on both? is there a noticeable difference? Is one wired vs wireless? If both systems are using edge and both have the same extensions installed...and it works well in one but not the other... it can't be the extension... there has to be something different on the laptop vs the desktop.

On Sat, Apr 6, 2024 at 6:06 PM Scott Leckie @.***> wrote:

Huh... just seen what you mean by "what is the extension that is counting while the page is loading?" That's ublock origin

I just disabled it on the laptop (the one with slowish performance) and it makes no difference - still behaves as per the video

— Reply to this email directly, view it on GitHub https://github.com/FMaz008/VineHelper/issues/82#issuecomment-2041217209, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG5LZ7ULYZGFSLQQ2APRITY4BWXXAVCNFSM6AAAAABFOICB36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGIYTOMRQHE . You are receiving this because you commented.Message ID: @.***>

-- Daniel Peel

-- Daniel Peel

skotl commented 5 months ago

Did an ookla speed test on both and they are effectively the same at around 250Mb/sec down and 110Mb/sec up, download latency from 18 to 89ms (both are on 5GHz channel)

I'm happy to close the issue if there's no smoking gun - the only reason I had opened it was that I've been using VH on this laptop for a few months and the "lagging" only seemed to start a couple of weeks back.

skotl commented 5 months ago

Closing as it seems that this is only affecting me, and only on one device