FMotalleb / nu_plugin_image

MIT License
11 stars 4 forks source link

accept the file output path as the first argument, not a `--output-path` #9

Closed maxim-uvarov closed 7 months ago

maxim-uvarov commented 7 months ago

Hello! Please, consider accepting the file output file path as the first argument, not a --output-path

like ls | table | to png 'first.png'

also, I believe it would be convinient to be able to omit the filename. You can just create new files with the timestamps like in nushell:

> date now | format date "%Y%m%d_%H%M%S_%3f" | $in + '.png'
20240222_133135_011.png

P.S. this plugin is super cool! Thank you so much for developing it!!! I was wanting this feature many times!!!

maxim-uvarov commented 7 months ago

Well, the suggestion is definitely not a big deal, as everything can be done with a custom command easily. Please, don't hesitate to reject! 🙏

maxim-uvarov commented 4 months ago

@FMotalleb thank you for implementing the! I have one more suggestion: when using automatic name - it would convenient to output back to terminal the name of created image. Maybe you'll find this useful too 🙏

FMotalleb commented 4 months ago

implemented in #f12d69f32e448e05aca97ac2354ecb5ea488f37d