FN-FAL113 / FN-FAL-s-Amplifications

An addon that includes FN Solar Generator, Material Generator, Machinery, Mystery Sticks, Gears of Friction, Power Xpansion and many more!
GNU General Public License v3.0
12 stars 13 forks source link

Fast Leveling of FN gear in PVP disabled worldguard regions exploit #73

Closed cybermancerr closed 2 years ago

cybermancerr commented 2 years ago

Multiple players where able to boost eachother's armor levels by just hitting eachother without doing any damage in none PVP worldguard regions. Need to make it that FN weapons and armor gear respect none PVP region flags.

FN-FAL113 commented 2 years ago

I'll put a fix on this, but it will be based if the attacker can place blocks in the location that is protected or not

cybermancerr commented 2 years ago

the problem is that the players are in a PVE world only and are just hitting each other without doing any damage anywhere in the none pvp world and are still able to exploit. The worldguard flag is "/rg global flag pvp deny". Took a player 10 minutes to max out the armor set using this exploit with a autoclicker with his buddy trying to hit him in non land claimed pvp deny world.

cybermancerr commented 2 years ago

/sf versions output: SensibleToolbox vDEV - 46 (git 904daaed) SfChunkInfo vDEV - 4 (git 1859e1a8) FNAmplifications vDEV - 64 (git a701f9d8) SimpleMaterialGenerators vDEV - 4 (git 5543cc8f) DynaTech vDEV - 160 (git e1075a1c) ExtraGear vDEV - 13 (git c62047e2) SFAdvancements vDEV - 14 (git 682f7776) CMILib v1.1.2.4 InfinityExpansion vDEV - 137 (git 4b326e08) SFCalc vDEV - 37 (git dfc0fc41) ElectricSpawners vDEV - 23 (git 6ec96773) EMC2 vDEV - 11 (git 89b4400a) ExtraHeads vDEV - 23 (git 0b59a770) VillagerUtil vDEV - 1 (git 0a949b19) MobCapturer vDEV - 17 (git c21b00a5) SlimyTreeTaps vDEV - 20 (git 963f0383) FlowerPower vDEV - 13 (git 06ad45dc) SlimeTinker vDEV - 72 (git bb2ef153) TranscEndence vDEV - 41 (git 98d7d47e) Galactifun vDEV - 59 (git 871aec03) FluffyMachines vDEV - 111 (git 51416696) DyedBackpacks vDEV - 17 (git 8b329e96) SoundMuffler vDEV - 23 (git 2030f464) AlchimiaVitae vDEV - 19 (git 24ffb2a5) HardcoreSlimefun v1.0 SlimefunWarfare vDEV - 79 (git 11f4e7e9) EcoPower vDEV - 5 (git 5c1ecd68) ExoticGarden vDEV - 78 (git 7f9a5f63) HeadLimiter vDEV - 13 (git 8c976b11) DankTech2 vDEV - 4 (git 803760fb) Liquid vDEV - 14 (git 0f5346bf) LiteXpansion vDEV - 174 (git e36d509d) SFMobDrops vDEV - 6 (git d36aba47) SimpleUtils vDEV - 15 (git 4250fd5e) ElementManipulation vDEV - 18 (git ce2c6165) SoulJars vDEV - 23 (git b8358a1f) EquivalencyTech v${project.version} SimpleStorage vDEV - 10 (git ea5e5637) PotionExpansion vDEV - 5 (git e2cfcd8a) SlimyRepair vDEV - 4 (git 790c41cb) INFO08:30:14 [RobertS13]() issued server command: /homes 08:30:20 [Geyser-Spigot]: /184.151.37.30:52506 tried to connect! 08:30:22 [Geyser-Spigot]: Player connected with username ArcticTree5027 08:30:42 [RobertS13]() lost connection: Disconnected [RobertS13]() left the game 08:31:41 [Geyser-Spigot]: Bedrock user with ip: /184.151.37.30 has disconnected for reason Bedrock client disconnected 08:32:38 [ajoobe]() issued server command: /shop 08:32:42 [EconomyShopGUI]: �2�k||�3�lDEV�2�k||�c�l[ajoobe]()�6�k|�5�lMOD�4�k|�r bought 2112 x Coal for $43,520 with the buy stacks screen. 08:32:51 ajoobe issued server command: /shop 08:32:55 [EconomyShopGUI]: �2�k||�3�lDEV�2�k||�c�lajoobe�6�k|�5�lMOD�4�k|�r bought 2112 x Block of Quartz for $117,504 with the buy stacks screen. 08:33:00 [UncleUhoh]() issued server command: /home WARN08:33:00 [UncleUhoh]() moved too quickly! 39.36742682609702,17.0,-58.857845129695306 08:33:02 [UncleUhoh]() moved too quickly! 0.0,-11.0,0.0 [UncleUhoh]() moved too quickly! 0.0,-12.0,0.0 INFO08:33:03 [ajoobe]() issued server command: /shop 08:33:09 [EconomyShopGUI]: �2�k||�3�lDEV�2�k||�c�lajoobe�6�k|�5�lMOD�4�k|�r bought 2112 x Redstone for $14,361.60 with the buy stacks screen. 08:34:07 [DankTech2]: DankTech2 saving data. [CrystamaeHistoria]: Crystamae saving data. WARN08:34:19 [UncleUhoh]() moved too quickly! 0.0,-11.0,0.0 INFO08:35:47 [Slimefun]: Auto-saving block data... (Next auto-save: 10m) [Slimefun]: Saving block data for world "world" (505,593 change(s) queued) [Slimefun]: Auto-saved all player data for 2 player(s)! 08:35:48 [Slimefun]: Saving block data for world "world_galactifun_earth_orbit" (2 change(s) queued) 08:36:13 Named entity EntityZombie['[Papillon_petit]()'s Guardian'/4868905, uuid='79acc51b-bb87-45bd-b4a3-9af214baea9c', l='ServerLevel[world]', x=2158.30, y=83.80, z=513.48, cpos=[134, 32], tl=11324, v=true]: died: [Papillon_petit]()'s Guardian suffocated in a wall 08:37:10 [Romanovski]() issued server command: /rg flags 08:37:15 [Romanovski]() issued server command: /rg flags -w "world" -p 2 global 08:37:19 [Romanovski]() issued server command: /rg flags -w "world" -p 3 global 08:37:21 [Romanovski]() issued server command: /rg flags -w "world" -p 4 global 08:37:23 [Romanovski]() issued server command: /rg flags -w "world" -p 5 global 08:37:24 [Romanovski]() issued server command: /rg flags -w "world" -p 6 global 08:37:28 [Romanovski]() issued server command: /rg flags -w "world" -p 7 global [Romanovski]() issued server command: /rg flags -w "world" -p 8 global 08:37:29 [Romanovski]() issued server command: /rg flags -w "world" -p 9 global 08:37:33 [Romanovski]() issued server command: /rg flags -w "world" -p 8 global 08:37:36 [Romanovski]() issued server command: /rg flags -w "world" -p 7 global [Romanovski]() issued server command: /rg flags -w "world" -p 6 global [Romanovski]() issued server command: /rg flags -w "world" -p 5 global 08:37:37 [Romanovski]() issued server command: /rg flags -w "world" -p 4 global [Romanovski]() issued server command: /rg flags -w "world" -p 3 global [Romanovski]() issued server command: /rg flags -w "world" -p 2 global 08:37:38 [Romanovski]() issued server command: /rg flags -w "world" -p 1 global 08:38:56 [zAuctionHouseV3 v3.0.8.6]: Z:\AMPDatastore\Instances\MCparty-Survival\Minecraft\plugins\zAuctionHouseV3\items.json successfully saved !

cybermancerr commented 2 years ago

Note: when one player attack another player with FN armor and does no damage because PVP is disabled, the FN armor still levels up is really the issue.

FN-FAL113 commented 2 years ago

The only workaeound for this is like the one I mentioned from thw previous pr which is expanding the vertical. Since I universally use break blocks in slimefun's permission system as a condition to check if player has this permission on that particularl location, but I will try adding the check if player can attack other player

cybermancerr commented 2 years ago

Awesome. Thank you.