FN-FAL113 / cs2-server-picker

A portable and lightweight server picker windows app for Counter Strike 2!
GNU General Public License v3.0
223 stars 12 forks source link

Suggestion to avoid hard-coding server IPs #5

Closed Chopper1337 closed 1 year ago

Chopper1337 commented 1 year ago

You currently hard code the servers and their IPs which isn't ideal as you'd need to keep this application updated whenever Valve change those IPs.

You could instead use https://api.steampowered.com/ISteamApps/GetSDRConfig/v1?appid=730 and parse the response to get the server list from Valve directly.

I would create a PR for this but I don't know VB.

FN-FAL113 commented 1 year ago

You currently hard code the servers and their IPs which isn't ideal as you'd need to keep this application updated whenever Valve change those IPs.

You could instead use https://api.steampowered.com/ISteamApps/GetSDRConfig/v1?appid=730 and parse the response to get the server list from Valve directly.

I would create a PR for this but I don't know VB.

its part of the todo below the readme of this project, I'm currently reviewing how valve update their server ip's if they only do update the host range then it will be fine else I should fetch the data

FN-FAL113 commented 1 year ago

Pr's are welcome but not forced :D but for now if they update the whole ip I should implement fetching data

FN-FAL113 commented 1 year ago

Just want to update, this one is on progress now. Just got the time to implement it :D