search

FNA-XNA / FAudio

FAudio - Accuracy-focused XAudio reimplementation for open platforms
https://fna-xna.github.io/
Other
534 stars 72 forks source link

build: fix __attribute__((aligned(x))) on gcc/clang #334

Closed rkitover closed 3 months ago

rkitover commented 3 months ago

This is a followup on 81d5a24 (build: fix building with MSVC, 2024-03-07).

Fix the missing trailing _ in attribute for __attribute((aligned(x))).

flibitijibibo commented 3 months ago

This isn't safe AFAIK, but we've been using this for some time now... I'll forward this to the Apple peoples on the FNA Discord to see what might be up.

rkitover commented 3 months ago

Would you support selectively increasing the C standard to 11 only on clang for the time being?

flibitijibibo commented 3 months ago

That would probably be okay, though we're still trying to figure out if there's a way to make this work correctly on M1. Will make the call this weekend!

kiddkaffeine commented 3 months ago

@rkitover, did this exist prior to the other change, or is it a regression? How does it manifest? Crash? Corrupted audio? Is this specific to M1? Wouldn't it affect iOS/tvOS as well?

rkitover commented 3 months ago

@flibitijibibo I'm sorry, but this was all caused because I made a typo, I wrote __attribute_ instead of __attribute__, this works correctly now.