Shared Memory Manager - Githubissues

FNA-XNA / FNA3D

FNA3D - 3D Graphics Library for FNA

http://fna-xna.github.io/

Other

267 stars 44 forks source link

Shared Memory Manager #172

Closed flibitijibibo closed 1 year ago

flibitijibibo commented 1 year ago

This diff as a whole looks horrible, so definitely use the commit history instead!

Mostly looking for two types of reviews:

@thatcosmonaut, make sure I didn't explode the Vulkan renderer in the process >_>
@TheSpydog, give this draft a try and see if we need to make changes to accommodate the other renderers

Known Issues:

[x] ~~I forgot to migrate needDefrag and friends to Memory.c~~ Reverted this
[x] ~~Track device-local max heap use in the allocator?~~ Nope
[x] Need to remove dedicated allocation from Vulkan side
[x] The void* is just directly cast to VkDeviceMemory, which is kinda bad
[x] VULKAN_Memory_CreateBufferHandle can be simplified (IMO)
[x] VULKAN_Memory_MarkBufferHandlesForDestroy needs to include the whole array passed to it

flibitijibibo commented 1 year ago

All of the FIXMEs except for the VkDeviceMemory casting have been resolved - miraculously this fixed most of the ugliness of the git diff as well, so once we know this is okay I'll squash this in. (Or at least, I'll squash all the commits up until now, would be nice to fix the flicker we found in the Wizorb trace.)