search

FNAL-HCAL-Ph1Upgrade / gui-step1

A small gui for the first step in the QIE testing process
0 stars 1 forks source link

Fail Faster #2

Closed caleb-james-smith closed 6 years ago

caleb-james-smith commented 6 years ago

Quit earlier if there are I2C problems (say no QIE card or no backplane power). Use sys.exit() with a helpful message. Do not attempt to read temperature and perform Igloo test.

bcmcms commented 6 years ago

A proposed fix has been submitted in #7 avoiding sys.exit(). The reasoning was that restarting the GUI every time someone selects a slot without a card (possibly accidentally) could lead to problems.

caleb-james-smith commented 6 years ago

Yes, thanks. We don't want to restart the GUI for I2C_ERRORS.

caleb-james-smith commented 6 years ago

I can see the commit https://github.com/BaylorCMS/gui-step1/pull/7/commits/50da53718c119b05d7a8372118f259fe692972ee

caleb-james-smith commented 6 years ago

But I don't see that change in the merge, which is weird: https://github.com/BaylorCMS/gui-step1/pull/7/files

bcmcms commented 6 years ago

That's because it had a merge conflict with a fix you already pulled into master. Rather than revert your work, I removed my edits.

caleb-james-smith commented 6 years ago

Great. We will close this.